From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0C4ACD54B0 for ; Tue, 19 Sep 2023 10:20:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229641AbjISKUM (ORCPT ); Tue, 19 Sep 2023 06:20:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43126 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230132AbjISKUL (ORCPT ); Tue, 19 Sep 2023 06:20:11 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C7110F5; Tue, 19 Sep 2023 03:20:03 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 928FBC433C8; Tue, 19 Sep 2023 10:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695118803; bh=vVqBizXlIr57susmkCRr/3LQlvrykLiMDIwyT0LtmDA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s/kHgsZQ7y3PwnFZvHrG8Pc5mH0FGR12eIoIfRIOaE+A8mHNg7q4s9b9klbTsVLxN 7G+f/hKoL+uqUa2loh4cRIpYIEPdJWeIU6VM2ppDlXtW9AvdJ4HctIEZjRSExWOoh+ bW1QdMm2Jw1RJG3fNUWVB0QUUwpHp6ClChAVH5BOSmShG/FI3f2/+YYLI1HpxTT130 gPVXKDtnSMCodOWZHswIXm3s41kGfDjUHcn7BztGvgGOiw7CaPJY+ISiyOP6ylgHpL ZgmgrmiZJikvm234V0z+x6KaTlpCzEzUCLquAcV2kdinSPO05rk6S6d/ecaUwqEE3V atZxUyUut0MBw== Date: Tue, 19 Sep 2023 12:19:59 +0200 From: Wolfram Sang To: Catalin Marinas Cc: Jan Bottorff , Serge Semin , Yann Sionneau , Will Deacon , Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Jan Dabros , Andi Shyti , Philipp Zabel , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Yann Sionneau Subject: Re: [PATCH v2] i2c: designware: Fix corrupted memory seen in the ISR Message-ID: Mail-Followup-To: Wolfram Sang , Catalin Marinas , Jan Bottorff , Serge Semin , Yann Sionneau , Will Deacon , Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Jan Dabros , Andi Shyti , Philipp Zabel , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Yann Sionneau References: <20230913232938.420423-1-janb@os.amperecomputing.com> <37e10c3d-b5ab-75ec-3c96-76e15eb9bef8@sionneau.net> <9de89e14-35bd-415d-97f1-4b6db1258997@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="cO6/IsiqUl9vEhfN" Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --cO6/IsiqUl9vEhfN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > I also agree that a wmb() in the i2c driver is not the more elegant fix. > For similar reasons, we hid barriers in the write*() macros, drivers > need to stay architecture-agnostic as much as possible. Exactly my thinking. I wanted to read this patch discussion later this week. But from glimpsing at it so far, I already wondered why there isn't a memory barrier in the final accessor to the register. --cO6/IsiqUl9vEhfN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmUJdcsACgkQFA3kzBSg KbZ34xAApSejksqgrOmtvdFYNIlyfKQ/dmCvH5upVR9s2uBzYf4OW2DfKk9V2pQs Z6ZXZnao8LkOH2+qpxkFYz7glDSYOQAEIp7r+bcHvvXRQp5JaJc0a+5riq0WXNmP yPlF86yrTb9Lkv5NqCxGU6O8sxsnSvGecjC/Ej6TiU7iNCdsamrbHUkYAcPpmNaW xg1Ei+fI5rSbz1Ty6cVVZ33rjqN5rpssISVvHwTZ/1pOJiEJYnFA/i8ZhDboAeWJ DKR3XvELgGx3W73Np/HfR2qZb43Iz25guH98/2r4GwH3hIVdLDfq92f+hkm1hziT FSoqgVL8XATHf52FTC8wJODqxpJnOafd+BBV7sazQ9xQR1BX0GWIGSdE/gCLsrfl wpQhN2OOWuWwiE8eZK9azgnZqxDtg1RjNpiCNNI4fft/XT0LuWLp5AW+M6bG1k85 AW5jMrjuXuLyNeLH+B8NBBsxz0mDgy0hBs+ZKMdICSl+fVQfjT753qEPoJQbLKLH Qc+PaFiH/T0PXKISwv1R9eshHmLeZDmCzDVjoDzJMQzk7XSqcn07wQnWmeE2yMMh AnLFfNfL4qhw6+15dEVIFQqfu5MIDGvAqCMuP7iZ6hi+CWiGkBflCXFEi9WAvrPY h/u69r7U3sNViIfNcigbiLR6GGDTs1Mmn27gfxvRaYrmkpxBiIw= =X2+z -----END PGP SIGNATURE----- --cO6/IsiqUl9vEhfN--