Re: [PATCH v2] i2c: designware: Fix corrupted memory seen in the ISR

Wolfram Sang
2023-09-27T19:38:14Z

[-- Attachment #1: Type: text/plain, Size: 820 bytes --]

> So my next question, is the change to dw_reg_write something that I should
> write and submit, or should someone else submit something more generalized,
> like option 2 above? I don't own the i2c driver, I'm just trying to fix one
> issue on one processor with minimal risk of breaking something. I don't have
> the broader view of what's optimal for the whole DesignWare i2c driver. I
> also don't have any way to test changes on other models of processors.

Well, I guess this is a question for the designware maintainers: do we
want this one conversion from *_relaxed to non-relaxed. Or are we
playing safe by using non-relaxed all the time. I would suggest the
latter because the drivers I look after hardly write registers in a hot
path (and not many of them at a time). But you guys know your driver
better...

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]