From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EE0BCE79A9 for ; Tue, 19 Sep 2023 19:53:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232036AbjISTxl (ORCPT ); Tue, 19 Sep 2023 15:53:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52372 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232873AbjISTxk (ORCPT ); Tue, 19 Sep 2023 15:53:40 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C607F3 for ; Tue, 19 Sep 2023 12:53:34 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A40B0C433C8; Tue, 19 Sep 2023 19:53:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695153214; bh=gGMfuet93LQ7soZIER3Pdhw/3YbOOIvpZXSiGrqUZ/Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=IFjRpGO8KWUE52IIYfNhH3KnOyGNSkVRd00M+gLT3NfZb8OqRi1eW5owzXZx8W/Vp et93HMyip1BcoYpJA1jZj/Igjx+RWCf3Yre4IpiHGUsy071/eL/VU8L8sfjkpvUJuO 0puD17T6XLpkjzP9JWxLx3ZX6Xk2wnvl7QY9JxdQ0vBZAxyhojo/x2NinRcQ+VS4tw 349pSoz8TQWtFLkBWsPVD/58djIG8b8lO23/fXJ40NDBOXT8XMw1Rw/z7DpXPIh5RS iwuFwCO99ZukTffKwep8QAmf3HA3OFGzRzV5fwPc1uhXOU7QvIBRwRpc0wF3n9F0Z1 4FFFMh+sR0sFQ== Date: Tue, 19 Sep 2023 21:53:27 +0200 From: Wolfram Sang To: Heiner Kallweit Cc: Jean Delvare , Andi Shyti , "linux-i2c@vger.kernel.org" Subject: Re: [PATCH] i2c: i801: add helper i801_restore_regs Message-ID: Mail-Followup-To: Wolfram Sang , Heiner Kallweit , Jean Delvare , Andi Shyti , "linux-i2c@vger.kernel.org" References: <94271a34-dbf5-440a-9f53-dc27b8384812@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="B1rUf3FHrVFkoTss" Content-Disposition: inline In-Reply-To: <94271a34-dbf5-440a-9f53-dc27b8384812@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --B1rUf3FHrVFkoTss Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Sep 18, 2023 at 01:57:01PM +0200, Heiner Kallweit wrote: > In few places relevant registers are reset to their initial value on > driver load. Factor this out to new helper i801_restore_regs to avoid > code duplication. > Even though no actual problems are known, this patch may contribute > to avoiding potential issues by: > - restoring register values also in the error path of i2c_add_adapter > - making restoring registers the last step (especially in i801_remove) >=20 > Signed-off-by: Heiner Kallweit Applied to for-next, thanks! --B1rUf3FHrVFkoTss Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmUJ/DMACgkQFA3kzBSg KbZH/BAAkY/W5HT8CHE+Or9voo45MjhccLAFp6n24ed2Lje5lT0ii1jXj5V2H54n xA5nnnAByOaH/YAYAcNRCjw7rjt5cWIUZN0IeOJyW7z7hw7GcLw2qqC4CUOxIq2/ xIAc5fwMX18RaxkPv+gLhhHL3DOWqaIjvvgNEojPx0502fNipALkMd26pfo946d5 K9Yk3aRILa3Kuu0aEY3l3b+ThULAQoNmL36p21kGcjb9nbWztL11M1EQQSeXZbeY 9W4yYdRbd6zjw2pPOVbTvI7IUm9Ou8mmxbFixp1wAEvVP8jogjaR9wwWNW54xgAM 9CjdE4q8oh0zHFz1zPPbipS/N8BQKeVt5MTufpwFLUoQlQ0fkWuS/HA5S6KO+eWS hfcsJcxlNulNpCgxm8WpNoVcTj5Tq30lgLUgzkev2c4Ci5RiRDIwJ1VZyw/toPNN g8PQd+HLoOp3Ft1+zQCMUmS0SV9MWK/EE5s1DM3/oaPt7pCavo4CA3c0o8Jv3rQs 7a00/Yhgh99UtImdJgbLZlpWvj4FrCmjAMhJMW3xRctoWd+Fi0iZA03X3OK2/X75 girKO+XDOmvUDXDJfA11Zlk+DEPVI1W+WczXE7Ex2fH0RLtzlYScqxGuzdACfMF+ Apslr14xYRt7NQTGUbOo14lsi/BiptXG2QRoQ2pDGpokTvll2yc= =Ro5H -----END PGP SIGNATURE----- --B1rUf3FHrVFkoTss--