From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B366CE79CB for ; Wed, 20 Sep 2023 11:05:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234346AbjITLFW (ORCPT ); Wed, 20 Sep 2023 07:05:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39782 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234335AbjITLFV (ORCPT ); Wed, 20 Sep 2023 07:05:21 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C4801CA; Wed, 20 Sep 2023 04:05:14 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C9C93C433C8; Wed, 20 Sep 2023 11:05:11 +0000 (UTC) Date: Wed, 20 Sep 2023 12:05:09 +0100 From: Catalin Marinas To: Jan Bottorff Cc: Yann Sionneau , Wolfram Sang , Serge Semin , Yann Sionneau , Will Deacon , Jarkko Nikula , Andy Shevchenko , Mika Westerberg , Jan Dabros , Andi Shyti , Philipp Zabel , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] i2c: designware: Fix corrupted memory seen in the ISR Message-ID: References: <37e10c3d-b5ab-75ec-3c96-76e15eb9bef8@sionneau.net> <9de89e14-35bd-415d-97f1-4b6db1258997@os.amperecomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org On Wed, Sep 20, 2023 at 11:44:58AM +0100, Catalin Marinas wrote: > On Tue, Sep 19, 2023 at 11:54:10AM -0700, Jan Bottorff wrote: > > The ARM docs do have a specific example case where the device write triggers > > an interrupt, and that example specifically says a DSB barrier is needed. > > Yeah, the Arm ARM is not very precise here on what the mailbox is, > whether it's a local or shared peripheral and they went for the > stronger DMB. Will added a good explanation on why a DMB is sufficient ^^^ DSB (fixing typo in my reply) -- Catalin