From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Tam Nguyen <tamnguyenchi@os.amperecomputing.com>
Cc: linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
patches@amperecomputing.com, jarkko.nikula@linux.intel.com,
mika.westerberg@linux.intel.com, jsd@semihalf.com,
chuong@os.amperecomputing.com, darren@os.amperecomputing.com,
stable@vger.kernel.org
Subject: Re: [PATCH v1] i2c: designware: Disable TX_EMPTY irq while waiting for block length byte
Date: Tue, 3 Oct 2023 11:57:58 +0300 [thread overview]
Message-ID: <ZRvXlqCcEuwR7YzM@smile.fi.intel.com> (raw)
In-Reply-To: <20230929035356.6435-1-tamnguyenchi@os.amperecomputing.com>
On Fri, Sep 29, 2023 at 10:53:56AM +0700, Tam Nguyen wrote:
> During SMBus block data read process, we have seen high interrupt rate
> because of TX_EMPTY irq status while waiting for block length byte (the
> first data byte after the address phase). The interrupt handler does not
> do anything because the internal state is kept as STATUS_WRITE_IN_PROGRESS.
> Hence, we should disable TX_EMPTY irq until I2C DW receives first data
IRQ
DesignWare
> byte from I2C device, then re-enable it.
>
> It takes 0.789 ms for host to receive data length from slave.
> Without the patch, i2c_dw_isr is called 99 times by TX_EMPTY interrupt.
i2c_dw_isr()
> And it is none after applying the patch.
> Cc: stable@vger.kernel.org
> Signed-off-by: Chuong Tran <chuong@os.amperecomputing.com>
Who is this guy? Do you need Co-developed-by tag?
> Signed-off-by: Tam Nguyen <tamnguyenchi@os.amperecomputing.com>
Other than that, agree with Serge's points.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-10-03 8:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 3:53 [PATCH v1] i2c: designware: Disable TX_EMPTY irq while waiting for block length byte Tam Nguyen
2023-09-29 13:43 ` Jarkko Nikula
2023-09-29 16:08 ` Serge Semin
2023-10-16 2:47 ` Tam Chi Nguyen
2023-10-03 8:11 ` Yann Sionneau
2023-10-16 2:52 ` Tam Chi Nguyen
2023-10-03 8:57 ` Andy Shevchenko [this message]
2023-10-16 2:51 ` Tam Chi Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZRvXlqCcEuwR7YzM@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=chuong@os.amperecomputing.com \
--cc=darren@os.amperecomputing.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=patches@amperecomputing.com \
--cc=stable@vger.kernel.org \
--cc=tamnguyenchi@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox