From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CDC49CD8CB5 for ; Tue, 10 Oct 2023 19:34:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234229AbjJJTe2 (ORCPT ); Tue, 10 Oct 2023 15:34:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45026 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230195AbjJJTe1 (ORCPT ); Tue, 10 Oct 2023 15:34:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A599299; Tue, 10 Oct 2023 12:34:24 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 81378C433C7; Tue, 10 Oct 2023 19:34:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1696966464; bh=fdAjM/1OHOG19BZ3uAI1dllH2avLjsk/EooV7MDjJgY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sjEUUrCLTkOqda/EDGq3rqFQL27cCC0sWlwDYfWSn0D0EiFxkgUEZC5+sVWcfMh6p 6iNtYYozsc1ijRS8K7FaaJjhnVK7M51VTwu5wmQx83UCRnOgcj2HIt6jblVzbfiVoz NMNqpg/ySEJf5MswnHewO3sVfbuUYq/T7WPTq24hz0scNpmcTtXemEjc5kSBdsjafs L3wpY6LcnNxEq6RolngYppPelbkzXnSBL8w5TSShgNwe7YoNScyBYeZESJstmkaa1H mV5JDhLEcLcxXN+3SBj16wf7U5DmLFRq6YdX6YHkP+wfbX1j1Z0OP8/kEzN1HYVouk 6tTHvPaeoIGqA== Date: Tue, 10 Oct 2023 21:34:20 +0200 From: Wolfram Sang To: Jian Zhang Cc: brendan.higgins@linux.dev, benh@kernel.crashing.org, joel@jms.id.au, andrew@aj.id.au, zhangjian3032@gmail.com, yulei.sh@bytedance.com, xiexinnan@bytedance.com, Andi Shyti , Andrew Jeffery , Tommy Huang , "open list:ARM/ASPEED I2C DRIVER" , "moderated list:ARM/ASPEED I2C DRIVER" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list Subject: Re: [PATCH v3] i2c: aspeed: Fix i2c bus hang in slave read Message-ID: Mail-Followup-To: Wolfram Sang , Jian Zhang , brendan.higgins@linux.dev, benh@kernel.crashing.org, joel@jms.id.au, andrew@aj.id.au, zhangjian3032@gmail.com, yulei.sh@bytedance.com, xiexinnan@bytedance.com, Andi Shyti , Andrew Jeffery , Tommy Huang , "open list:ARM/ASPEED I2C DRIVER" , "moderated list:ARM/ASPEED I2C DRIVER" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , open list References: <20231006022233.3963590-1-zhangjian.3032@bytedance.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="h+tNCvmT9ovOY6AN" Content-Disposition: inline In-Reply-To: <20231006022233.3963590-1-zhangjian.3032@bytedance.com> Precedence: bulk List-ID: X-Mailing-List: linux-i2c@vger.kernel.org --h+tNCvmT9ovOY6AN Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Oct 06, 2023 at 10:22:33AM +0800, Jian Zhang wrote: > When the `CONFIG_I2C_SLAVE` option is enabled and the device operates > as a slave, a situation arises where the master sends a START signal > without the accompanying STOP signal. This action results in a > persistent I2C bus timeout. The core issue stems from the fact that > the i2c controller remains in a slave read state without a timeout > mechanism. As a consequence, the bus perpetually experiences timeouts. >=20 > In this case, the i2c bus will be reset, but the slave_state reset is > missing. >=20 > Fixes: fee465150b45 ("i2c: aspeed: Reset the i2c controller when timeout = occurs") > Signed-off-by: Jian Zhang > Acked-by: Andi Shyti > Tested-by: Andrew Jeffery > Reviewed-by: Andrew Jeffery >=20 Applied to for-current, thanks! --h+tNCvmT9ovOY6AN Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmUlpzgACgkQFA3kzBSg KbZ/7RAAihe3k0z4CpvqtiXFm+M8WD2j0iyfOzn0Q3Rv+NN+Y7hVMAxsDs0hTUiJ 81zj8PMMrBkMnEPhv0ytT7QKrv8N65H2ONXGmWtOPLinn2UsMSMtM53zNLg2iR5M ASKLLr5gSqaTjJao9FCYKWP7G5rwYqF8gEcmp/S0aA2ElyGfkvOf9J3n92iwMRaV CO859fdKlSaINuHIEw1Uh7q8ThdXAdON94vVDAREXPWax3Qle2fAMFjxEQQaBrbL uUlBJuRwExDegv56w6RPmbA0CQ6M/BxEviFm2thICeg6Q94UAFXTQWg6Wyirdhrz ufVHS8JZf1481aK4iUw3IFrIgRV7tTFfO8WVoQUn5EJZTZ2K1KB16RUgPdrUJebg 9sAxLJ6u4H+Hu0FeL/k8zd7IcQJkoJlUm3IkEsHSWGc/tGQ0kolAAKbQjLs8778/ LLo6c9qyVnhFyh60WaOAzppRyK/R1+UmJWYZYSozwk8lZ8OkUsrWHLH5hWa7tMyW ZkoBrjSvGWjAfib9kLvpgtalcNwlOLr//RP9bT27IblhWiz63VUT8p2G1gqND5p8 jcyodY25zHqFDIpy/AdMVjzqupmSw3upInMOgnJqyeMCEigh2OdL8voL6dxBAQ0m 2rhGFIrH4BzpaUun1KA3zSjwuY84qDYGB54Rz9ng01MTh/9G1bs= =VdsG -----END PGP SIGNATURE----- --h+tNCvmT9ovOY6AN--