Re: [PATCH] dt-bindings: i2c: i2c-demux-pinctrl: Convert to json-schema

Wolfram Sang
2023-10-23T15:21:24Z

[-- Attachment #1: Type: text/plain, Size: 2110 bytes --]

Hi Geert,

On Mon, Oct 23, 2023 at 03:53:00PM +0200, Geert Uytterhoeven wrote:
> Convert the pinctrl-based I2C bus demultiplexer Device Tree binding
> documentation to json-schema.
>
> Update the example to match reality.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---

Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

One minor nit:

> + hdmi@39 {
> + compatible = "adi,adv7511w";
> + reg = <0x39>;
> + interrupt-parent = <&gpio1>;
> + interrupts = <15 IRQ_TYPE_LEVEL_LOW>;
> + clocks = <&cec_clock>;
> + clock-names = "cec";
> +
> + avdd-supply = <&fixedregulator1v8>;
> + dvdd-supply = <&fixedregulator1v8>;
> + pvdd-supply = <&fixedregulator1v8>;
> + dvdd-3v-supply = <&fixedregulator3v3>;
> + bgvdd-supply = <&fixedregulator1v8>;
> +
> + adi,input-depth = <8>;
> + adi,input-colorspace = "rgb";
> + adi,input-clock = "1x";
> +
> + ports {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + port@0 {
> + reg = <0>;
> + adv7511_in: endpoint {
> + remote-endpoint = <&lvds0_out>;
> + };
> + };
> +
> + port@1 {
> + reg = <1>;
> + adv7511_out: endpoint {
> + remote-endpoint = <&hdmi_con_out>;
> + };
> + };
> + };
> + };

Let's drop this huge hunk. It doesn't add value for demuxer.

Thanks for doing this!

Wolfram

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]