From: Wolfram Sang <wsa@kernel.org>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: gregory.clement@bootlin.com, andi.shyti@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: i2c: mv64xxx: add reset-gpios property
Date: Thu, 26 Oct 2023 13:15:55 +0200 [thread overview]
Message-ID: <ZTpKa7R/xxKeCo+z@ninjato> (raw)
In-Reply-To: <20231024223032.3387487-2-chris.packham@alliedtelesis.co.nz>
[-- Attachment #1: Type: text/plain, Size: 451 bytes --]
> + reset-gpios:
> + description:
> + GPIO pin providing a common reset for all downstream devices. This GPIO
> + will be asserted then released before the downstream devices are probed.
How about renaming this to "bus-reset-gpios"?
Reason: When I read "reset-gpios", then I assume the device itself will
be reset. In this case, the Marvell I2C controller. Some I2C mux devices
and PCA9564 already use the property like I described.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-10-26 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-24 22:30 [PATCH v4 0/2] i2c: mv64xxx: reset-gpios Chris Packham
2023-10-24 22:30 ` [PATCH v4 1/2] dt-bindings: i2c: mv64xxx: add reset-gpios property Chris Packham
2023-10-24 23:29 ` Andi Shyti
2023-10-26 11:15 ` Wolfram Sang [this message]
2023-10-26 20:04 ` Chris Packham
2023-10-24 22:30 ` [PATCH v4 2/2] i2c: mv64xxx: add an optional " Chris Packham
2023-10-24 23:30 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZTpKa7R/xxKeCo+z@ninjato \
--to=wsa@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox