Linux I2C development
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: "linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] i2c: Mark I2C_CLASS_DDC as deprecated and emit warning if adapters declare support for it
Date: Thu, 26 Oct 2023 19:37:44 +0200	[thread overview]
Message-ID: <ZTqj6BKcNYzEkZpp@shikoro> (raw)
In-Reply-To: <5c521229-18be-47dc-baa9-cabd78420cad@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 673 bytes --]

Hi Heiner!

> With removal of the legacy eeprom driver the only i2c client device
> driver with I2C_CLASS_DDC is gone, so it's time to mark I2C_CLASS_DDC
> as deprecated.

OK, but I will need to wait until the eeprom-removal hits mainline.

> Use pr_warn_once, because graphics adapters can have several i2c
> busses and we may see the warning multiple times otherwise.
> 
> Note:
> Driver staging/olpc_dcon declares support for classes HWMON and DDC,
> but only HWMON is used with the scx200_acb adapter driver on olpc
> devices.

And why don't we remove its DDC declaration here in this patch?

Thanks for cleaning this up!

Regards,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2023-10-26 17:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-11  9:26 [PATCH] i2c: Mark I2C_CLASS_DDC as deprecated and emit warning if adapters declare support for it Heiner Kallweit
2023-10-26 17:37 ` Wolfram Sang [this message]
2023-10-26 20:22   ` Heiner Kallweit
2023-10-31  6:43   ` Heiner Kallweit
2023-10-31  8:55     ` Wolfram Sang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZTqj6BKcNYzEkZpp@shikoro \
    --to=wsa@kernel.org \
    --cc=hkallweit1@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox