From: Wolfram Sang <wsa@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
linux-media@vger.kernel.org,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
linux-samsung-soc@vger.kernel.org,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH] media: exynos4-is: fimc-is-i2c: remove I2C_CLASS_SPD support
Date: Thu, 23 Nov 2023 21:59:13 +0100 [thread overview]
Message-ID: <ZV+9Iauj5y7q8R6H@ninjato> (raw)
In-Reply-To: <e4395454-c500-4d76-af74-42e29d4b40d8@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1238 bytes --]
On Wed, Nov 08, 2023 at 07:42:37AM +0100, Heiner Kallweit wrote:
> This I2C bus is used by the firmware only and it seems I2C_CLASS_SPD
> device auto-detection has never been used. So we can safely remove it.
> That's one further step towards removing I2C_CLASS_SPD completely.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
As I want to apply this cleanup early in the cycle, could we have an ack
for me to modify this subsystem via I2C, please?
> ---
> drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c b/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
> index bef6e9b4a..44363c424 100644
> --- a/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
> +++ b/drivers/media/platform/samsung/exynos4-is/fimc-is-i2c.c
> @@ -57,7 +57,6 @@ static int fimc_is_i2c_probe(struct platform_device *pdev)
> strscpy(i2c_adap->name, "exynos4x12-isp-i2c", sizeof(i2c_adap->name));
> i2c_adap->owner = THIS_MODULE;
> i2c_adap->algo = &fimc_is_i2c_algorithm;
> - i2c_adap->class = I2C_CLASS_SPD;
>
> platform_set_drvdata(pdev, isp_i2c);
> pm_runtime_enable(&pdev->dev);
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-11-23 20:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-08 6:42 [PATCH] media: exynos4-is: fimc-is-i2c: remove I2C_CLASS_SPD support Heiner Kallweit
2023-11-23 20:59 ` Wolfram Sang [this message]
2023-11-23 21:37 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZV+9Iauj5y7q8R6H@ninjato \
--to=wsa@kernel.org \
--cc=alim.akhtar@samsung.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=s.nawrocki@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox