From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JZRyFXkw" Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CA5F0D48; Thu, 30 Nov 2023 05:28:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1701350904; x=1732886904; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=ghr+ezRKo3dkSi3M8C6UorBjmizIlKFEixhMc9v7FuQ=; b=JZRyFXkwsJor42bwB5QyvAtMoZHpMHeRfnh6aranOBz8kQ+60+XoL3mU MJorakhkFM2nUFqX4cfKI7ucOdKInV7ujDUdHjBIKVMYHnhmvB0QMYLOe Gys9Zxm5+UmyHmHU85qBXEbwt7RfQsQuucJcI/0corgE35Z5mBYxvJhgy 92nlzCRWz8iwbr8nhOKYwG+qyhs4whS36lEhFauexnx02NCgfehW+3Mt4 nQxD2AtweapRMhe96HAxvm6ElXjNw/tph6fVGmM82g5nzz3JDpU09qstX BnCOUgKK3kTXd6TPEGaXrVK5oAgWiFRTEdmBB4Ck1I2esdibEFKmsT9Io A==; X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="392187071" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="392187071" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 05:28:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10910"; a="769307685" X-IronPort-AV: E=Sophos;i="6.04,239,1695711600"; d="scan'208";a="769307685" Received: from smile.fi.intel.com ([10.237.72.54]) by orsmga002.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Nov 2023 05:28:21 -0800 Received: from andy by smile.fi.intel.com with local (Exim 4.97) (envelope-from ) id 1r8h5W-00000000ht8-1SQQ; Thu, 30 Nov 2023 15:28:18 +0200 Date: Thu, 30 Nov 2023 15:28:18 +0200 From: Andy Shevchenko To: Andi Shyti Cc: Mario Limonciello , Jarkko Nikula , Herbert Xu , Wolfram Sang , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, Mika Westerberg , Jan Dabros , Philipp Zabel Subject: Re: [PATCH v4 19/24] i2c: designware: Uninline i2c_dw_probe() Message-ID: References: <20231120144641.1660574-1-andriy.shevchenko@linux.intel.com> <20231120144641.1660574-20-andriy.shevchenko@linux.intel.com> <20231129232151.ueum2axn74qzuzes@zenone.zhora.eu> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231129232151.ueum2axn74qzuzes@zenone.zhora.eu> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Thu, Nov 30, 2023 at 12:21:51AM +0100, Andi Shyti wrote: > Hi Andy, > > On Mon, Nov 20, 2023 at 04:42:01PM +0200, Andy Shevchenko wrote: > > Since i2c_dw_probe() is going to be extended, uninline it to reduce > > the noise in the common header. > > where is it going to be extended? It's not in thie series. I'm > fine with the patch anyway as it cleans up the header file. It's used to be in the previous versions of the series where I have device_set_node() API to be used. -- With Best Regards, Andy Shevchenko