From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Mark Hasemeyer <markhas@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Raul Rangel <rrangel@chromium.org>,
Bartosz Golaszewski <brgl@bgdev.pl>, Len Brown <lenb@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Wolfram Sang <wsa@kernel.org>,
linux-acpi@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v1 1/6] gpiolib: acpi: Modify acpi_dev_irq_wake_get_by to use resource
Date: Wed, 13 Dec 2023 21:34:55 +0200 [thread overview]
Message-ID: <ZXoHXwmwzczAqlLv@smile.fi.intel.com> (raw)
In-Reply-To: <20231213110009.v1.1.Ifd0903f1c351e84376d71dbdadbd43931197f5ea@changeid>
On Wed, Dec 13, 2023 at 11:00:19AM -0700, Mark Hasemeyer wrote:
> Other information besides wake capability can be provided about GPIO
> IRQs such as triggering, polarity, and sharability. Use resource flags
> to provide this information to the caller if they want it.
>
> This should keep the API more robust over time as flags are added,
> modified, or removed. It also more closely matches acpi_irq_get which
acpi_irq_get()
> take a resource as an argument.
>
> Rename the function to acpi_dev_get_gpio_irq_resource to better describe
acpi_dev_get_gpio_irq_resource()
> the function's new behavior.
...
> + * @r: pointer to resource to populate with irq information. It is not modified on failure.
IRQ
I don't think the second remark is even needed. It's usual approach, i.e.
we expect no changes in the output if error condition is met.
...
> + * Irq number will be available in the resource structure.
IRQ
...
> + *r = (struct resource)DEFINE_RES_IRQ(irq);
Why do you need "(struct resource)" annotation?
...
> + struct resource irqres;
> struct i2c_acpi_irq_context irq_ctx = {
> .irq = -ENOENT,
> };
Hmm... I'm wondering if we can reuse irqres as a context to the respective
lookup calls.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-12-13 19:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 18:00 [PATCH v1 1/6] gpiolib: acpi: Modify acpi_dev_irq_wake_get_by to use resource Mark Hasemeyer
2023-12-13 19:34 ` Andy Shevchenko [this message]
2023-12-14 20:56 ` Mark Hasemeyer
2023-12-13 19:40 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZXoHXwmwzczAqlLv@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=brgl@bgdev.pl \
--cc=lenb@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=markhas@chromium.org \
--cc=mika.westerberg@linux.intel.com \
--cc=rafael@kernel.org \
--cc=rrangel@chromium.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox