Re: [PATCH RFC v2] platform/x86: p2sb: Allow p2sb_bar() calls during PCI device probe

Andy Shevchenko
2023-12-14T14:13:10Z

On Thu, Dec 14, 2023 at 12:55:36AM +0000, Shinichiro Kawasaki wrote:
> On Dec 13, 2023 / 16:05, Andy Shevchenko wrote:
> > On Tue, Dec 12, 2023 at 08:47:46PM +0900, Shin'ichiro Kawasaki wrote:

...

> > > +/* Cache BAR0 of P2SB device from function 0 ot 7 */
> > > +#define NR_P2SB_RES_CACHE 8
> >
> > Here... (at least some better comment with TODO needs to be added,
> > and next patches can address that).
> >
> > > struct resource *bar0 = &pdev->resource[0];
> >
> > ...and here... (okay, not exactly here, but with the same idea,
> > to use pci_resource_n() macro)
> >
> > > + if (!PCI_FUNC(devfn_p2sb)) {
> > > + slot_p2sb = PCI_SLOT(devfn_p2sb);
> > > + for (fn = 1; fn < 8; fn++)
> >
> > ...and here...
> >
> > > + p2sb_scan_and_cache(bus, PCI_DEVFN(slot_p2sb, fn));
> > > + }
> >
> > ...and so on I gave comments. Any reason why they left unaddressed?
>
> Andy, thanks for the response, but I'm not sure about the comments you gave.
> I guess you responded to the RFC v1 patch but it somehow did not reach to me,
> probably. According to the lore archive, only Hans responded to the RFC v1 [1].
> If this guess is correct, could you resend your comments on the RFC v1?

Oh, my... It seems the message was never delivered and I haven't paid attention
on the bounces.

Give me time, I'll try to restore the review from my memory and will send
a new email.

> [1] https://lore.kernel.org/platform-driver-x86/20231201104759.949340-1-shinichiro.kawasaki@wdc.com/

--
With Best Regards,
Andy Shevchenko