From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55DB2221572; Wed, 16 Apr 2025 07:02:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.13 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744786943; cv=none; b=sfq28OmvCA1RjKWrqVDn4pxapKQtxLqdeTWaT1wSLKu6iJkdLQDWc5cZ61CSuqodvTlWLRsYKAiBc37Uo6+Vx++Fj9OkKmPydCeazFKanuq2LTN4B0rQFttYjaQcvxjVzMYjTpYeYLfpvlRtkqIbsys9ULxmYE/+S9T4T5Q/3H0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744786943; c=relaxed/simple; bh=vC9qu2x28cbxmK7VJr+Bv79rWkNOEx2eUdan3K30uI0=; h=Date:From:To:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Var3LST7uVTyyQjNFcUe0N71RLYOHHxCxb1LtJqU6J4XqubYJay0YbfLvWgYmXUnKO2Ci+wNkxAhS/pMUDbN82oTZesdX1nGH1vqwuoJFvZtBnbV3NznvjMggD33Ybj1wMbAtLHBM3zmVDij3pqZHL8whVE/ZRqka1PQVPwmO1s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=GjfSR7Ka; arc=none smtp.client-ip=192.198.163.13 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="GjfSR7Ka" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1744786941; x=1776322941; h=date:from:to:subject:message-id:references:mime-version: in-reply-to; bh=vC9qu2x28cbxmK7VJr+Bv79rWkNOEx2eUdan3K30uI0=; b=GjfSR7KakS9Ni2ufnsU6nokwTrhzSjqcd38j4yeiA4cFVFi0/pMbiyId 1Iz38FswTDbs/Jf/6b4QXY26Ugo+emMJxZsJCW4sXHHaMbGsF1vdn89wX AeoRLV2EsImLSsjoPj1zRmlTOJzSRxEEaIIlPpMFKafUSVAsSiYuYigxi H1zyQiVkX671LBAT3ADT/w5wtn/OU9Y4yGZRchCgDf/KkWnf7a1yN/KR7 S/TigyFI0iEBJBkqLoS8H8l9epJwpm/YpMij7uprazeQQ3AMnToXSojlH x8AfimAaem79b+yPwQt+JLxqV3dtQAIhZuXywKb+k3c0d5p8ulY43Zele Q==; X-CSE-ConnectionGUID: bq3/ZRTOQaKqyOS8c/SHbg== X-CSE-MsgGUID: eESMnd4OQnGGWipTVPs47g== X-IronPort-AV: E=McAfee;i="6700,10204,11404"; a="49016428" X-IronPort-AV: E=Sophos;i="6.15,215,1739865600"; d="scan'208";a="49016428" Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2025 00:02:20 -0700 X-CSE-ConnectionGUID: 3xCPRFkrQH+OdM2dLByN/w== X-CSE-MsgGUID: +j+Anc7CRfmXx+9z0ZOrzg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,215,1739865600"; d="scan'208";a="130370786" Received: from smile.fi.intel.com ([10.237.72.58]) by fmviesa007.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Apr 2025 00:02:18 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98.2) (envelope-from ) id 1u4wml-0000000Cm2v-3loF; Wed, 16 Apr 2025 10:02:15 +0300 Date: Wed, 16 Apr 2025 10:02:15 +0300 From: Andy Shevchenko To: Wolfram Sang , Sakari Ailus , Mauro Carvalho Chehab , Tomi Valkeinen , Jai Luthra , linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab Subject: Re: [PATCH v4 5/7] i2c: core: Do not dereference fwnode in struct device Message-ID: References: <20250414100409.3910312-1-andriy.shevchenko@linux.intel.com> <20250414100409.3910312-6-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo On Wed, Apr 16, 2025 at 08:55:27AM +0200, Wolfram Sang wrote: > On Mon, Apr 14, 2025 at 01:01:55PM +0300, Andy Shevchenko wrote: > > In order to make the underneath API easier to change in the future, > > prevent users from dereferencing fwnode from struct device. > > Instead, use the specific device_set_node() API for that. > > > > Tested-by: Tomi Valkeinen > > Reviewed-by: Sakari Ailus > > Acked-by: Sakari Ailus > > Signed-off-by: Andy Shevchenko > > I'll check this patch later today. Rest of the series looks good to me > already. Note, I'm planning to send a v5 shortly with the style fixes and commit messages as you suggested. -- With Best Regards, Andy Shevchenko