From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79A9521D3F4; Wed, 16 Apr 2025 07:58:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744790307; cv=none; b=qbJhPdVk02EZwzmmM3hYzS/BHMMwlswNy6vqeHdIuxzKo6HVG4VEdp2vHEsAiXG1TY0w5uOtLVR5WSYO9xJgZXGVIuc+cAMHTisfGW3ipRkaO4grsTsLynt19fuC5CwCOYPG8CjwZy+wA1tHh5J5Pzn1kcY+yER2aKSQG7ILmKs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744790307; c=relaxed/simple; bh=g8YPW39hxmx5YvNcbfIuiJT1dut85FSOVUEZdSWmv5Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=IOLKeqrpDzfRGLEaUfa7pRQDRUHVh4e6ca65wwn+Rfr2bTD1i1nROlxWAkXBVMZ0tRGslxODsvw2OfbdkHm+iRrlR6Vav/8ZXAg0gEzjG/LlwL2LLi9pwp5YKnwl5A0i26MB/nIPSqmHksSBRyT7B1Yq4NIjE63lHjzcgawQVEU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=AxUdxyRr; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="AxUdxyRr" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FA2DC4CEE2; Wed, 16 Apr 2025 07:58:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744790306; bh=g8YPW39hxmx5YvNcbfIuiJT1dut85FSOVUEZdSWmv5Q=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AxUdxyRr+0hwSePWXRQg5uJqs1WDb20uf76494nsnCj+SUjMJiZ7ntGelXhOqX0TJ cHHuJ+LrlQVB7xPfdqMD+LhYExgPondKE7L+fn3oJXQfUJUq0rRJ95WxSmQ5W1f0Cw OxZ2PFpK6WqXaUHfz94IKBCUCt5FOWv366Wba2ALriB1H/bdwapOhX076N9hCD+iab i2jMditYsnNLPgxXvH3u32wZXdtIDIjq+EUUt0eQR3t5hnJLQ+pZ0z2TjvVs6VSx70 ZQgy4w3bszc0ZbepNphCNR9JwUh8VvKZZQPPcq0gJuyx61jSVxUbFOr/4oWyWii0yf tn9AWX93yb+yQ== Date: Wed, 16 Apr 2025 09:58:20 +0200 From: Ingo Molnar To: Yazen Ghannam Cc: Mario Limonciello , Borislav Petkov , Jean Delvare , Andi Shyti , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Jonathan Corbet , Mario Limonciello , Thomas Gleixner , Ingo Molnar , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H . Peter Anvin" , Shyam Sundar S K , Hans de Goede , "open list:DOCUMENTATION" , open list , "open list:I2C/SMBUS CONTROLLER DRIVERS FOR PC" , "open list:AMD PMC DRIVER" Subject: Re: [PATCH v4 4/5] platform/x86/amd: pmc: use FCH_PM_BASE definition Message-ID: References: <20250415002658.1320419-1-superm1@kernel.org> <20250415002658.1320419-5-superm1@kernel.org> <20250415151326.GA624550@yaz-khff2.amd.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250415151326.GA624550@yaz-khff2.amd.com> * Yazen Ghannam wrote: > On Mon, Apr 14, 2025 at 07:26:57PM -0500, Mario Limonciello wrote: > > From: Mario Limonciello > > > > The s2idle mmio quirk uses a scratch register in the FCH. > > Adjust the code to clarify that. > > > > Signed-off-by: Mario Limonciello > > --- > > v4: > > * Use fch.h instead > > --- > > arch/x86/include/asm/amd/fch.h | 1 + > > drivers/platform/x86/amd/pmc/pmc-quirks.c | 3 ++- > > 2 files changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/arch/x86/include/asm/amd/fch.h b/arch/x86/include/asm/amd/fch.h > > index a5fd91ff92df3..9b32e8a03193e 100644 > > --- a/arch/x86/include/asm/amd/fch.h > > +++ b/arch/x86/include/asm/amd/fch.h > > @@ -8,5 +8,6 @@ > > /* register offsets from PM base */ > > #define FCH_PM_DECODEEN 0x00 > > #define FCH_PM_DECODEEN_SMBUS0SEL GENMASK(20, 19) > > +#define FCH_PM_SCRATCH 0x80 > > > > #endif > > diff --git a/drivers/platform/x86/amd/pmc/pmc-quirks.c b/drivers/platform/x86/amd/pmc/pmc-quirks.c > > index b4f49720c87f6..3c680d2029f62 100644 > > --- a/drivers/platform/x86/amd/pmc/pmc-quirks.c > > +++ b/drivers/platform/x86/amd/pmc/pmc-quirks.c > > @@ -8,6 +8,7 @@ > > * Author: Mario Limonciello > > */ > > > > +#include > > Arch headers should go after linux headers, I think. That's true, but it's a mostly stylistic requirement these days. > So that arch stuff can override generic stuff. Arch headers that override generic stuff are very much supposed to be able to build stand-alone and in pretty much any order with other headers, with very few exceptions. Ordering dependencies are very much frowned upon, because if they don't trigger build failures they can result in subtle breakages. Thanks, Ingo