Re: Update driver xdpe152c4.c

Guenter Roeck
2025-04-07T14:36:14Z

On 4/7/25 07:01, Guenter Roeck wrote:
> On 4/6/25 23:15, Wolfram Sang wrote:
>>
>>> Please help to review the attached Linux Kernel patch for xdpe152xx driver.
>>
>> To shorten things, you could return -EAGAIN as an error code, then the
>> I2C core will retry the message for you. Within the configured limits
>> for the controller.
>>
>
> The patch neglects to state the _reason_ for the change.
>
> I'd like to know what causes the problem before applying a change like this.
> I suspect that the chip needs either a delay between accesses or a delay
> after a write. Both are supported by the PMBus core.
>

And this is a complete no-go:

+ if (ret < 0)
+ pr_warn("PMBUS READ ERROR:%d\n", ret);

It isn't even dev_warn(), and I am not going to accept patches which will
clog the kernel log for every single error return. Just imagine how the
kernel log would look like if every driver would log errors like this.

Guenter