From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C97991862; Sat, 12 Apr 2025 20:15:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744488935; cv=none; b=QUK43IBoWHHuTId+KXAz4g5vzxb8vEkjjjtzG2O0YQiGCWHp7dGZ9V2pH5iT/zgBfEgnDxgPBBAn5Ous7tRH4kXtrUXonXfazxu/O0eCTy86MsaUqmSmfTak88jc2IM6fbOeFdS9JtfnqzfNhIBaIuC42CnRq+NHLno8dpCbcqQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744488935; c=relaxed/simple; bh=Or+NMXs931Ofg2S4YMkEwk6tZqDrWdMNxO/CVa+/9io=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ciHTnfa9ptU/M4ibTknjfKRqWMqPB8dbk+D4SvBGQupuN8TRyxDzoqs7aIHg9vjPUcPamZWgVuRCAAcz/YBvE8TbsWhtiU/4sDgYmVICUjMMUzLTahWq5c2sfC6QHqL5igEpyFSB1LgEgFhCeepYq2jlJNR3Sy2O9nRsLWzIgMY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=S46yvMNp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="S46yvMNp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2C558C4CEE3; Sat, 12 Apr 2025 20:15:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1744488934; bh=Or+NMXs931Ofg2S4YMkEwk6tZqDrWdMNxO/CVa+/9io=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=S46yvMNpNSZtoKiOx3ftM4XHA2KLk6F5MMFnq9Vt+7EdFb8G3rMB1f2hm3G/rOR7n UdR3QfnAHEZYRbbWkBO2WIXbkCh7UM+jSO+z96xQ/rswcRROu6LisQCk6Yu1f1B4Ds NEoLWrRGIQ7+sZk98IAFpoiTNsKFmkFur0rnAElaaMp4J3U8DHAHLdzQzPoQ4cpkjx yxkcFhtxKWqFvMrkCres7h1+mHCNDX0aCPu5TgS9XgHdYrgzWr7bXMt9pylnOCFFZL 5M4yZFDfg/Jvsg2nppqPTmF82joadaRv2KDPKNW07JRddypUqi+gRWZ6iSoxNZzkAt nOXWKFznvGV2A== Date: Sat, 12 Apr 2025 22:15:27 +0200 From: Ingo Molnar To: Mario Limonciello Cc: Borislav Petkov , Jean Delvare , Andi Shyti , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Jonathan Corbet , Mario Limonciello , Yazen Ghannam , Thomas Gleixner , Ingo Molnar , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H . Peter Anvin" , Shyam Sundar S K , Hans de Goede , "open list:DOCUMENTATION" , open list , "open list:I2C/SMBUS CONTROLLER DRIVERS FOR PC" , "open list:AMD PMC DRIVER" Subject: Re: [PATCH v3 2/4] i2c: piix4: Move SB800_PIIX4_FCH_PM_ADDR definition to amd_node.h Message-ID: References: <20250410200202.2974062-1-superm1@kernel.org> <20250410200202.2974062-3-superm1@kernel.org> <20250411114908.GLZ_kBtN94h79EEN6j@fat_crate.local> <20250411124157.GDZ_kOFfsGgY4zUXA5@fat_crate.local> <5509f044-912b-4d10-bdeb-95ec52002b06@kernel.org> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5509f044-912b-4d10-bdeb-95ec52002b06@kernel.org> * Mario Limonciello wrote: > SB800 is pre-Zen stuff. It's "before my time" - I guess that's the > precursor to FCH being in the SoC but has the same functionality. > > So I'm thinking . I went by the SB800_PIIX4_FCH_PM_ADDR name, which is a misnomer these days? But yeah, sounds good to me too. Boris? and ... I'm sure you knew this was coming, but we should probably move *all* basic FCH_PM definitions into that header, such as SB800_PIIX4_FCH_PM_SIZE, and rename it to FCH_PM_SIZE or so? Thanks, Ingo