From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: ende.tan@starfivetech.com, linux-i2c@vger.kernel.org,
jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
jsd@semihalf.com, andi.shyti@kernel.org,
linux-kernel@vger.kernel.org, leyfoon.tan@starfivetech.com,
endeneer@gmail.com
Subject: Re: [v2,1/1] i2c: designware: Add SMBus Quick Command support
Date: Mon, 14 Apr 2025 10:43:07 +0200 [thread overview]
Message-ID: <Z_zKmx-60iWOjgs9@shikoro> (raw)
In-Reply-To: <Z_yxVJVc69ljaDZe@smile.fi.intel.com>
[-- Attachment #1: Type: text/plain, Size: 662 bytes --]
> > + /* i2c-core-smbus.c: Only I2C_SMBUS_QUICK has msg[0].len = 0 */
>
> Please, remove filenames from the code, better to refer to the actual functions
> as func(). This helps also to grep for all usages in case of renaming.
The comment can be removed. Regular I2C messages can also have a length
of 0.
> > + DW_IC_DEFAULT_FUNCTIONALITY;
Sidenote: Why do we have this define? It is used only once and makes
reading the actual functionalities harder, I'd say.
Also, I wonder if this patch really works in practice. The
I2C_AQ_NO_ZERO_LEN flag is still set, so the core should prevent such
messages to be passed on to the driver?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2025-04-14 8:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-12 9:34 [v2,1/1] i2c: designware: Add SMBus Quick Command support ende.tan
2025-04-14 6:55 ` Andy Shevchenko
2025-04-14 8:43 ` Wolfram Sang [this message]
2025-04-14 9:02 ` Wolfram Sang
2025-04-14 9:18 ` Jarkko Nikula
2025-04-14 14:16 ` Jarkko Nikula
2025-04-20 3:44 ` EnDe Tan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Z_zKmx-60iWOjgs9@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=ende.tan@starfivetech.com \
--cc=endeneer@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox