Re: [PATCH v3 13/18] phy: cadence-torrent: remove noop_ops phy operations

Andy Shevchenko
2024-02-15T15:45:39Z

On Thu, Feb 15, 2024 at 04:17:58PM +0100, Thomas Richard wrote:
> Even if a PHY is already configured, the PHY operations are needed during
> resume stage, as the PHY is in reset state.
> The noop_ops PHY operations is removed to always have PHY operations.
> The already_configured flag is checked at the begening of init, configure
> and poweron operations to keep the already_configured behaviour.

...

> + if (cdns_phy->already_configured) {
> + /* Give 5ms to 10ms delay for the PIPE clock to be stable */
> + usleep_range(5000, 10000);

fsleep() ?
(Yes, I see this is the original code, perhaps later in a separate change)

> + return 0;
> + }

--
With Best Regards,
Andy Shevchenko