Re: [PATCH v3 08/18] phy: ti: phy-j721e-wiz: split wiz_clock_init() function

Andy Shevchenko
2024-02-16T15:03:49Z

On Fri, Feb 16, 2024 at 02:34:39PM +0530, Siddharth Vadapalli wrote:
> On 24/02/16 11:32AM, Vinod Koul wrote:
> > On 15-02-24, 17:43, Andy Shevchenko wrote:
> > > On Thu, Feb 15, 2024 at 04:17:53PM +0100, Thomas Richard wrote:

...

> > > (Side note, as this can be done later)
> > >
> > > > if (rate >= 100000000)
> > >
> > > > + if (rate >= 100000000)
> > >
> > > > + if (rate >= 100000000)
> > >
> > > I would make local definition and use it, we may get the global one as there
> > > are users.
> > >
> > > #define HZ_PER_GHZ 1000000000UL
> >
> > Better to define as:
> > #define HZ_PER_GHZ 1 * GIGA
>
> The variable "rate" is being compared against 100 MHz and not 1 GHz.

Extremely good point why constant definitions are better (to avoid missing
or extra 0, etc)!

> The driver already has the following macros defined:
> #define REF_CLK_19_2MHZ 19200000
> #define REF_CLK_25MHZ 25000000
> #define REF_CLK_100MHZ 100000000
> #define REF_CLK_156_25MHZ 156250000
>
> So would it be acceptable to change it to:
> if (rate >= REF_CLK_100MHZ)
> instead?

Sounds like a good idea to me.

--
With Best Regards,
Andy Shevchenko