Re: [PATCH 10/13] i2c: nomadik: support Mobileye EyeQ5 I2C controller

Linus Walleij
2024-02-19T14:35:52Z

On Thu, Feb 15, 2024 at 5:52 PM Théo Lebrun <theo.lebrun@bootlin.com> wrote:

> Add compatible for the integration of the same DB8500 IP block into the
> Mobileye EyeQ5 platform. Two quirks are present:
>
> - The memory bus only supports 32-bit accesses. One writeb() is done to
> fill the Tx FIFO which we replace with a writel().
>
> - A register must be configured for the I2C speed mode; it is located
> in a shared register region called OLB. We access that memory region
> using a syscon & regmap that gets passed as a phandle (mobileye,olb).
>
> A two-bit enum per controller is written into the register; that
> requires us to know the global index of the I2C
> controller (mobileye,id).
>
> We add #include <linux/mfd/syscon.h> and <linux/regmap.h> and sort
> headers.
>
> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>

(...)

> - writeb(*priv->cli.buffer, priv->virtbase + I2C_TFR);
> + if (priv->has_32b_bus)
> + writel(*priv->cli.buffer, priv->virtbase + I2C_TFR);
> + else
> + writeb(*priv->cli.buffer, priv->virtbase + I2C_TFR);

Are the other byte accessors working flawlessly? I get the shivers.
If it's needed in one place I bet the others prefer 32bit access too.

Further the MIPS is big-endian is it not? It feels that this just happens
to work because of byte order access? writel() is little-endian by
definition.

What happens if you replace all writeb():s with something like

static void nmk_write_reg(struct nmk_i2c_dev *priv, u32 reg, u8 val)
{
if (IS_ENABLED(CONFIG_CPU_BIG_ENDIAN))
writeb(val, priv->virtbase + reg + 3);
// if this doesn't work then use writeb((u32)val,
priv->virtbase + reg) I guess
else
writeb(val, priv->virtbase + reg);
}

and conversely for readb()?

Other accessors such as iowrite* are perhaps viable in this case, I'm not sure.

Yours,
Linus Walleij