From: Wolfram Sang <wsa@kernel.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Andi Shyti <andi.shyti@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>
Subject: Re: [PATCH v2] i2c: smbus: Prepare i2c_register_spd for usage on muxed segments
Date: Mon, 4 Mar 2024 08:46:02 +0100 [thread overview]
Message-ID: <ZeV8Oi-j8L7ugyhR@ninjato> (raw)
In-Reply-To: <d0b4aa2e-8b5d-4c27-8aab-164a089d95bd@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
Hello Heiner,
> + dev_info(&adap->dev, "%d/%d memory slots populated (from DMI)\n",
> + dimm_count, slot_count);
I am still in favor of removing this. I don't like the inconsistency of
the printout depending on the bus being muxed or not. We still have one
printout per device instantiated.
If you agree, I can remove this while applying. If not, then I'll apply
as is. No strong opinion here on my side.
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-03-04 7:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-02 20:39 [PATCH v2] i2c: smbus: Prepare i2c_register_spd for usage on muxed segments Heiner Kallweit
2024-03-04 7:46 ` Wolfram Sang [this message]
2024-03-04 20:20 ` Heiner Kallweit
2024-03-04 20:46 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZeV8Oi-j8L7ugyhR@ninjato \
--to=wsa@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=hkallweit1@gmail.com \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox