Re: [PATCH 18/64] i2c: eg20t: reword according to newest specification

Andi Shyti
2024-03-26T19:18:19Z

Hi Wolfram,

On Fri, Mar 22, 2024 at 02:25:11PM +0100, Wolfram Sang wrote:
> Match the wording of this driver wrt. the newest I2C v7, SMBus 3.2, I3C
> specifications and replace "master/slave" with more appropriate terms.
> They are also more specific because we distinguish now between a remote
> entity ("client") and a local one ("target").
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
> drivers/i2c/busses/i2c-eg20t.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
> index 4914bfbee2a9..e95793036f5d 100644
> --- a/drivers/i2c/busses/i2c-eg20t.c
> +++ b/drivers/i2c/busses/i2c-eg20t.c
> @@ -337,7 +337,7 @@ static int pch_i2c_wait_for_check_xfer(struct i2c_algo_pch_data *adap)
> adap->pch_event_flag = 0;
>
> if (ioread32(p + PCH_I2CSR) & PCH_GETACK) {
> - pch_dbg(adap, "Receive NACK for slave address setting\n");
> + pch_dbg(adap, "Receive NACK for client address setting\n");
> return -ENXIO;
> }
>
> @@ -382,7 +382,7 @@ static s32 pch_i2c_writebytes(struct i2c_adapter *i2c_adap,
> buf = msgs->buf;
> addr = msgs->addr;
>
> - /* enable master tx */
> + /* enable host tx */

maybe we should also specify that we are using both host and
client for master in the commit message.

In any case,

Reviewed-by: Andi Shyti <andi.shyti@kernel.org>

Thanks,
Andi