Re: [PATCH v4] i2c: i2c-qcom-geni: Parse Error correctly in i2c GSI mode

Andi Shyti
2024-04-16T15:05:25Z

Hi Vinod, Mukesh,

On Sun, Apr 07, 2024 at 01:42:48PM +0530, Vinod Koul wrote:
> On 02-04-24, 18:44, Andi Shyti wrote:
> > On Fri, Mar 29, 2024 at 10:15:24PM +0530, Vinod Koul wrote:
> > > On 28-03-24, 08:36, Andi Shyti wrote:
> > > > On Wed, 13 Mar 2024 10:56:39 +0530, Mukesh Kumar Savaliya wrote:
> > > > > I2C driver currently reports "DMA txn failed" error even though it's
> > > > > NACK OR BUS_PROTO OR ARB_LOST. Detect NACK error when no device ACKs
> > > > > on the bus instead of generic transfer failure which doesn't give any
> > > > > specific clue.
> > > > >
> > > > > Make Changes inside i2c driver callback handler function
> > > > > i2c_gpi_cb_result() to parse these errors and make sure GSI driver
> > > > > stores the error status during error interrupt.
> > > > >
> > > > > [...]
> > > >
> > > > Applied to i2c/i2c-host-next on
> > > >
> > > > git://git.kernel.org/pub/scm/linux/kernel/git/local tree
> > >
> > > You applied changes to dmaengine driver without my ack! I dont agree to
> > > the approach here, we could do better
> >
> > this must be an error from b4 ty. The changes have been added to
> >
> > pub/scm/linux/kernel/git/andi.shyti/linux.git
> >
> > branch i2c/i2c-host, As it has been agreed from very long.
> >
> > Anyway, the changes are in -next. What do we do now? Do I revert
> > it? Mukesh, can you please agree with Vinod?
>
> I dont apply patches to other subsystem without the ack. Either way you
> can ask always!

Yes, you are totally right; but please, keep in mind that this
patch has some history and I would have loved to hear from you
earlier. Anyway...

> I will leave it upto you...

... Mukesh, I'm sorry, but I'm going to revert this patch again
until we address all the last minute issues from Vinod. The
silence on this thread is worrying me more than reverting it.

I hope this will be the last time I revert this patch.

Moreover, in order to avoid maintainers' rumble (:)), please
let's try to split patches that are touching more than one
subsystems keeping the logical meainings intact.

I hope this is fine with you, Vinod.

Andi