From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
Andi Shyti <andi.shyti@kernel.org>
Subject: Re: [PATCH v2 3/3] i2c: rcar: minor changes to adhere to coding style
Date: Sun, 7 Jul 2024 13:06:36 +0200 [thread overview]
Message-ID: <Zop2vNCrzDmEKKiO@shikoro> (raw)
In-Reply-To: <f93eda7e-e65f-42e9-b96d-e88290201ca0@web.de>
[-- Attachment #1: Type: text/plain, Size: 494 bytes --]
On Sun, Jul 07, 2024 at 12:34:36PM +0200, Markus Elfring wrote:
> > A newline was missing and closing braces of functions do not need a
> > semicolon.
>
> Can there be a need to offer such changes by separate update steps?
That would be too fine grained in my book.
> > return !!(rcar_i2c_read(priv, ICMCR) & FSCL);
> >
> > -};
> > +}
> …
>
> How do you think about to omit any blank lines at such source code places?
Oh yes, that newline should go as well. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-07-07 11:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-07 8:28 [PATCH v2 0/3] i2c: rcar: avoid spurious irqs Wolfram Sang
2024-07-07 8:28 ` [PATCH v2 1/3] i2c: rcar: bring hardware to known state when probing Wolfram Sang
2024-07-08 23:19 ` Andi Shyti
2024-07-07 8:28 ` [PATCH v2 2/3] i2c: rcar: WARN about spurious irqs Wolfram Sang
2024-07-07 8:28 ` [PATCH v2 3/3] i2c: rcar: minor changes to adhere to coding style Wolfram Sang
2024-07-07 10:34 ` Markus Elfring
2024-07-07 11:06 ` Wolfram Sang [this message]
2024-07-08 9:50 ` Wolfram Sang
2024-07-08 22:26 ` Andi Shyti
2024-07-10 6:29 ` Wolfram Sang
2024-07-10 8:02 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zop2vNCrzDmEKKiO@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=Markus.Elfring@web.de \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox