Re: [PATCH dt-schema 3/3] schemas: i2c: add generic interrupt name for I2C controllers

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 925 bytes --]

Hi Rob,

thanks for the super-fast review!

> > "smbus_alert" is a generic interrupt name for controllers, so document
> > it. Introduce also "irq" for the primary interrupt.
> 
> I wouldn't add "irq". It's kind of odd in that we have it for I2C
> devices in the first place and we don't try to do that anywhere else.

Yes, I am actually happy to remove "irq". I only added it for
consistency.

> > +  interrupt-names:
> > +    anyOf:
> > +      - {} # Any name is allowed.
> > +      - items:
> > +          enum:
> > +            - irq
> > +            - smbus_alert
> 
> It doesn't really matter with the {}, but the 2nd entry is only true
> if interrupt-names only contains these 2 names. I'd use 'contains'
> rather than 'items' here.

So, just replace "items:" with "contains:", right? Should I also change
this for I2C targets and add this chunk to patch 2?

All the best,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]