Re: [PATCH] i2c: core: Lock address during client device instantiation

[Wolfram Sang <wsa+renesas@sang-engineering.com>]

[-- Attachment #1: Type: text/plain, Size: 1018 bytes --]

Hi Heiner,

thanks for tackling this!

> +static int i2c_lock_addr(struct i2c_adapter *adap, unsigned short addr,
> +			 unsigned short flags)

What about just using 'struct i2c_client *client' here as an argument.
It has all we need and it currently seems unlikely that we need to call
it from somewhere else where we need this seperation.

> +	if (!(flags & I2C_CLIENT_TEN) && !(flags & I2C_CLIENT_SLAVE) &&

From a pedantic point of view, I don't see a reason for not handling
those two cases above. I hate to be pedantic because 10-bit mode is
practically unused (and I am tempted to remove support for it once in a
while because it makes other solutions clumsy). And the other one is
super unlikely to happen because the backends do not autoload. However,
it is theoretically possible if someone loads a devicetree overlay and
initiates via sysfs at the same time. I liked the solution with the
bitfield and atomic access, but maybe a linked list is better?

Happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]