public inbox for linux-i2c@vger.kernel.org
 help / color / mirror / Atom feed
From: Stefan Eichenberger <eichest@gmail.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: o.rempel@pengutronix.de, kernel@pengutronix.de,
	shawnguo@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
	Frank.Li@nxp.com, francesco.dolcini@toradex.com,
	linux-i2c@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Stefan Eichenberger <stefan.eichenberger@toradex.com>
Subject: Re: [PATCH v2 1/4] i2c: imx: only poll for bus busy in multi master mode
Date: Thu, 22 Aug 2024 09:03:55 +0200	[thread overview]
Message-ID: <Zsbi2xcxBGE7o9uE@eichest-laptop> (raw)
In-Reply-To: <zudo7zjlxqfxipsi2x7e4kyhckvkjreovrdmsfxp3m6clbbgzv@ina4j4qxu24r>

Hi Andi,

On Thu, Aug 22, 2024 at 12:21:30AM +0200, Andi Shyti wrote:
> Hi Stefan,
> 
> > @@ -1468,6 +1473,8 @@ static int i2c_imx_probe(struct platform_device *pdev)
> >  		goto rpm_disable;
> >  	}
> >  
> > +	i2c_imx->multi_master = of_property_read_bool(pdev->dev.of_node, "multi-master");
> > +
> 
> you might also want to add the multi-master boolean property in
> the binding.

We discussed this internally and weren't sure when it was required
because e.g. i2c-rcar and i2c-tegra don't have it documented in their
bindings. Is it still required if it is part of the dt-schema?
https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/i2c/i2c-controller.yaml

If so, I will add it in the next version.

Thanks,
Stefan

  reply	other threads:[~2024-08-22  7:03 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-19  7:19 [PATCH v2 0/4] i2c: imx: prevent rescheduling in non-dma mode Stefan Eichenberger
2024-08-19  7:19 ` [PATCH v2 1/4] i2c: imx: only poll for bus busy in multi master mode Stefan Eichenberger
2024-08-21 11:01   ` Fabio Estevam
2024-08-21 14:39     ` Oleksij Rempel
2024-08-21 15:23       ` Stefan Eichenberger
2024-08-21 16:43         ` Fabio Estevam
2024-08-21 22:31         ` Andi Shyti
2024-08-22  6:51     ` Oleksij Rempel
2024-08-22 11:07     ` Fabio Estevam
2024-08-22 11:50       ` Stefan Eichenberger
2024-08-22 12:59         ` Fabio Estevam
2024-08-23 13:43       ` Stefan Eichenberger
2024-08-21 22:21   ` Andi Shyti
2024-08-22  7:03     ` Stefan Eichenberger [this message]
2024-08-22 10:04       ` Oleksij Rempel
2024-08-22 12:03         ` Stefan Eichenberger
2024-08-23  0:35         ` Andi Shyti
2024-08-23 13:48           ` Stefan Eichenberger
2024-08-23 14:04             ` Oleksij Rempel
2024-08-23 14:42               ` Stefan Eichenberger
2024-08-19  7:19 ` [PATCH v2 2/4] i2c: imx: separate atomic, dma and non-dma use case Stefan Eichenberger
2024-08-30  7:31   ` Oleksij Rempel
2024-08-19  7:19 ` [PATCH v2 3/4] i2c: imx: use readb_relaxed and writeb_relaxed Stefan Eichenberger
2024-08-30  7:37   ` Oleksij Rempel
2024-08-19  7:19 ` [PATCH v2 4/4] i2c: imx: prevent rescheduling in non dma mode Stefan Eichenberger
2024-08-30  8:13   ` Oleksij Rempel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zsbi2xcxBGE7o9uE@eichest-laptop \
    --to=eichest@gmail.com \
    --cc=Frank.Li@nxp.com \
    --cc=andi.shyti@kernel.org \
    --cc=festevam@gmail.com \
    --cc=francesco.dolcini@toradex.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=o.rempel@pengutronix.de \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=stefan.eichenberger@toradex.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox