Re: [PATCH v2 1/4] i2c: imx: only poll for bus busy in multi master mode

[Oleksij Rempel <o.rempel@pengutronix.de>]

On Thu, Aug 22, 2024 at 09:03:55AM +0200, Stefan Eichenberger wrote:
> Hi Andi,
> 
> On Thu, Aug 22, 2024 at 12:21:30AM +0200, Andi Shyti wrote:
> > Hi Stefan,
> > 
> > > @@ -1468,6 +1473,8 @@ static int i2c_imx_probe(struct platform_device *pdev)
> > >  		goto rpm_disable;
> > >  	}
> > >  
> > > +	i2c_imx->multi_master = of_property_read_bool(pdev->dev.of_node, "multi-master");
> > > +
> > 
> > you might also want to add the multi-master boolean property in
> > the binding.
> 
> We discussed this internally and weren't sure when it was required
> because e.g. i2c-rcar and i2c-tegra don't have it documented in their
> bindings. Is it still required if it is part of the dt-schema?
> https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/i2c/i2c-controller.yaml

The i2c-imx.yaml has "unevaluatedProperties: false", which fill discard
every thing not in this yaml

> If so, I will add it in the next version.

Yes, please.

Regards,
Oleksij
-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |