From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.zeus03.de (zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E69917DFF1 for ; Tue, 10 Sep 2024 07:38:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725953891; cv=none; b=C8nq4lg7rgUA7SKwUrDLvziHPYyTfDhDxEnaVJRi+9a0CbGxRMgK4ikdUfy+2Yu4JTfQDLTDrWNrHjyIXR1EKRD585qMXmbDUrIuqjrGuu4PUYdf6Q5YcW7r9ZxcgwjJPQj4G8F8eLXnBfrTPqY3ckuKVQV/2boDJcpUhy9BnpI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725953891; c=relaxed/simple; bh=A01gXMPmdOVHjgOXLq8x6wngKiGp/+yBjNa3PTQtGUA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=EbgjYTGR3KjOwbPVgmZKM4p+ebGueC7bF+HHl+5mH2PgBon2vDIyWwpar+GDqX9Xnm53A2xHzdUiqAGGV/mV4Krpqobfz68p0LrDXBXp2cIcFH0xAOrcIy1SA5azdGAVUEIKRHEZS74MD1AbiVR86Lp+bRVJiQtRCrNFhBvoHBc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=LBhmRUZl; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="LBhmRUZl" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=iXV3 ojKVxtT97rHN1pIqykrcVcOxIMIMkSB7vjJvKwA=; b=LBhmRUZlsvNQ/pa6Fpdz 0TAqt0xsp2NEiEvRtx6BsugP0+Vk+LjbkL/ECMo05FlNseAM8EZahcniLj63WtnS VrsVUeTJ1XAVeLJohuhs7ul/8iGGroG0TFm6cmp5KIOK8uhq5TcuQrFUIiFGgltP C6DD7ILzxfjugO2mhgXfkXvxSVihIV8jvhkk9ng+jBoYGBli8+q5LLTecD1XDuYy RN9PN1W10UtIyDka106d06VicjnYCsU6+qngnzP64a+n5quwTC5/v76WimdL/Yu8 UL4R4zTohs0KXs3CRYphXQw0X/si2LSMyuRX7x7bnUtIhiKjT+x/B01d0m4uRjSJ Ig== Received: (qmail 143903 invoked from network); 10 Sep 2024 09:38:03 +0200 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 10 Sep 2024 09:38:03 +0200 X-UD-Smtp-Session: l3s3148p1@hfwY9L4hmyptKPK+ Date: Tue, 10 Sep 2024 09:38:02 +0200 From: Wolfram Sang To: Rob Herring Cc: Geert Uytterhoeven , linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree-spec@vger.kernel.org Subject: Re: [PATCH dt-schema] schemas: i2c: add optional GPIO binding for SMBALERT# line Message-ID: Mail-Followup-To: Wolfram Sang , Rob Herring , Geert Uytterhoeven , linux-renesas-soc@vger.kernel.org, linux-i2c@vger.kernel.org, devicetree-spec@vger.kernel.org References: <20240909105835.28531-1-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QyTWA7hLlIfVNX8Y" Content-Disposition: inline In-Reply-To: --QyTWA7hLlIfVNX8Y Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Hi Rob, thanks for your review! > I believe "gpios" is what was originally supported, but now it is > preferred if GPIOs are used as interrupts then we use interrupts in > DT. I had this originally in my RFC[1]. I got convinced by Geert's arguments because the DT snippet in the board DTS looked kinda ugly. The board needs to override the DTSI of the SoC to replace "interrupts" with "interrupts-extended": === &i2c3 { pinctrl-0 = <&i2c3_pins>; pinctrl-names = "i2c-pwr"; + + /delete-property/ interrupts; + interrupts-extended = <&gic GIC_SPI 290 IRQ_TYPE_LEVEL_HIGH>, <&gpio1 26 IRQ_TYPE_EDGE_FALLING>; + interrupt-names = "main", "smbus_alert"; + + smbus; }; === It works, though. All the best, Wolfram [1] http://patchwork.ozlabs.org/project/linux-i2c/patch/20240826150840.25497-5-wsa+renesas@sang-engineering.com/ --QyTWA7hLlIfVNX8Y Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmbf91YACgkQFA3kzBSg KbYMIBAAhfr2PCCicOUH5J2Alx4C3Slvz8g8jWcV+Wc2oUkpNFQ9dBb4XaGryGDB yaKyncFlXp52Nuap8WuClCg6PkxGDQ2m7QDEHPt3adt23WHENaflorE8NCTyIgWN NZyjeZcBKFGJSVHVF8GQ6OiKF5nN3r83osKZBi5zk/XorZlSFE1qz8VonyvZ5IAP kImLBW0GnPzS8rRNLGmyjMO5rEicOszqBeObPqB6xwXYqw55hccIdmuM6epWZCS3 /oc9WiuMGd9JXDJfZaJ4CaRFfP0UjiGyFR+AKIcR+CBh6C8y9Njv+CyU921zUICs UT6RaEalhpvaiJ0ibvXsps3c273t0VJW1cvhThiTwuDtZydlxJbL0et4zzOzyGSm syh44+071JflBUBVQDZW645DfnKIxlpAcDfzhgpHSbx0eOq9ODe7wZkKYnR/ag4X u5iN7nwQu45FpxOIWPIPytrp45ReYpuweXzVUQ286AQmB+Cjiy/k+MExzoZMX/RR Zz9NYJ0huLzAUGEm4OVz7KHBZxTlt6t5vZ+EYTMPQnng9Vl5/9vmdVQP1DjUVOca eXtaUNeao8pV54bpW0sVWwnr/yRabI5MxnCmzMaHOyBq2HKUH1vBGBdLhbK5TjsT l3OnJgXjhpVyQUWGK4Urs6kpSvTqHo2gAml6zGizPN9lMclU1iM= =JUVA -----END PGP SIGNATURE----- --QyTWA7hLlIfVNX8Y--