From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Heiner Kallweit <hkallweit1@gmail.com>,
Wolfram Sang <wsa@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] driver core: class: warn if a compatibility class is registered
Date: Tue, 3 Sep 2024 11:04:44 +0200 [thread overview]
Message-ID: <ZtbRLOUO48PzOKmC@shikoro> (raw)
In-Reply-To: <2024090242-smother-preview-a1d2@gregkh>
[-- Attachment #1: Type: text/plain, Size: 778 bytes --]
> > + pr_warn("Compatibility class %s will go away soon, please migrate userspace tools to use bus devices\n",
> > + name);
>
> That's not going to do anything except annoy users who have no control
> over this, sorry. Please just fix up all of the kernel and then delete
> this function.
So, we deprecated this sysfs-class 15 years ago and hid it with a
Kconfig symbol. However, we never pursued this further, so e.g. Debian
has the Kconfig symbol still enabled. Can we really remove this from one
release to the next without another transition period? I am not afraid
of tools like lm-sensors which were converted long ago. But custom code
might rely on sysfs-paths created by this class. It was even advertised
in IPMI docs until last week (fixed now).
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-09-03 9:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 19:00 [PATCH 0/2] i2c: core: prepare dropping support for I2C_COMPAT Heiner Kallweit
2024-09-02 19:01 ` [PATCH 1/2] i2c: core: Switch I2C_COMPAT to default n Heiner Kallweit
2024-09-03 8:49 ` Greg Kroah-Hartman
2024-09-02 19:02 ` [PATCH 2/2] driver core: class: warn if a compatibility class is registered Heiner Kallweit
2024-09-02 19:20 ` Greg Kroah-Hartman
2024-09-03 9:04 ` Wolfram Sang [this message]
2024-09-03 9:06 ` Wolfram Sang
2024-09-03 10:06 ` Greg Kroah-Hartman
2024-09-03 10:43 ` Wolfram Sang
2024-09-03 10:50 ` Greg Kroah-Hartman
2024-09-03 11:09 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtbRLOUO48PzOKmC@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).