From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Chen-Yu Tsai <wenst@chromium.org>
Cc: Rob Herring <robh@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Wolfram Sang <wsa@kernel.org>, Benson Leung <bleung@chromium.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
chrome-platform@lists.linux.dev, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
Douglas Anderson <dianders@chromium.org>,
Johan Hovold <johan@kernel.org>, Jiri Kosina <jikos@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH v6 11/12] platform/chrome: Introduce device tree hardware prober
Date: Wed, 4 Sep 2024 10:08:22 +0000 [thread overview]
Message-ID: <Ztgxlmhnkn7NVC81@google.com> (raw)
In-Reply-To: <20240904090016.2841572-12-wenst@chromium.org>
On Wed, Sep 04, 2024 at 05:00:13PM +0800, Chen-Yu Tsai wrote:
> diff --git a/drivers/platform/chrome/chromeos_of_hw_prober.c b/drivers/platform/chrome/chromeos_of_hw_prober.c
[...]
> +static int chromeos_of_hw_prober_probe(struct platform_device *pdev)
> +{
> + for (size_t i = 0; i < ARRAY_SIZE(hw_prober_platforms); i++) {
> + int ret;
> +
> + if (!of_machine_is_compatible(hw_prober_platforms[i].compatible))
> + continue;
> +
> + ret = hw_prober_platforms[i].prober(&pdev->dev, hw_prober_platforms[i].data);
> + /* Ignore unrecoverable errors and keep going through other probers */
> + if (ret == -EPROBE_DEFER)
> + return ret;
Is it harmless if some of the components get probed multiple times? E.g.:
comp1 probed -> comp2 probed -> comp3 returned -EPROBE_DEFER -> some time
later, chromeos_of_hw_prober_probe() gets called again.
next prev parent reply other threads:[~2024-09-04 10:08 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 9:00 [PATCH v6 00/12] platform/chrome: Introduce DT hardware prober Chen-Yu Tsai
2024-09-04 9:00 ` [PATCH v6 01/12] of: dynamic: Add of_changeset_update_prop_string Chen-Yu Tsai
2024-09-04 9:00 ` [PATCH v6 02/12] of: base: Add for_each_child_of_node_with_prefix_scoped() Chen-Yu Tsai
2024-09-04 13:03 ` Andy Shevchenko
2024-09-04 13:43 ` Rob Herring
2024-09-04 9:00 ` [PATCH v6 03/12] regulator: Move OF-specific regulator lookup code to of_regulator.c Chen-Yu Tsai
2024-09-04 13:09 ` Andy Shevchenko
2024-09-04 13:14 ` Andy Shevchenko
2024-09-05 8:11 ` Chen-Yu Tsai
2024-09-05 8:29 ` Andy Shevchenko
2024-09-04 9:00 ` [PATCH v6 04/12] regulator: Split up _regulator_get() Chen-Yu Tsai
2024-09-04 9:00 ` [PATCH v6 05/12] regulator: Do pure DT regulator lookup in of_regulator_bulk_get_all() Chen-Yu Tsai
2024-09-04 13:13 ` Andy Shevchenko
2024-09-09 2:39 ` Chen-Yu Tsai
2024-09-04 9:00 ` [PATCH v6 06/12] gpiolib: Add gpio_get_property_name_length() Chen-Yu Tsai
2024-09-04 13:40 ` Andy Shevchenko
2024-09-09 2:45 ` Chen-Yu Tsai
2024-09-11 7:37 ` Chen-Yu Tsai
2024-09-11 14:39 ` Andy Shevchenko
2024-09-04 9:00 ` [PATCH v6 07/12] i2c: core: Remove extra space in Makefile Chen-Yu Tsai
2024-09-04 13:41 ` Andy Shevchenko
2024-09-04 9:00 ` [PATCH v6 08/12] i2c: Introduce OF component probe function Chen-Yu Tsai
2024-09-04 13:47 ` Andy Shevchenko
2024-09-09 3:02 ` Chen-Yu Tsai
2024-09-04 15:37 ` Rob Herring
2024-09-04 9:00 ` [PATCH v6 09/12] i2c: of-prober: Add regulator support Chen-Yu Tsai
2024-09-04 13:53 ` Andy Shevchenko
2024-09-04 22:57 ` Doug Anderson
2024-09-05 15:10 ` Chen-Yu Tsai
2024-09-05 18:14 ` Doug Anderson
2024-09-05 18:42 ` Mark Brown
2024-09-05 19:13 ` Andy Shevchenko
2024-09-06 3:45 ` Chen-Yu Tsai
2024-09-11 0:30 ` Doug Anderson
2024-09-11 6:12 ` Chen-Yu Tsai
2024-09-11 14:38 ` Andy Shevchenko
2024-09-11 14:49 ` Mark Brown
2024-09-04 9:00 ` [PATCH v6 10/12] i2c: of-prober: Add GPIO support Chen-Yu Tsai
2024-09-04 14:04 ` Andy Shevchenko
2024-09-04 9:00 ` [PATCH v6 11/12] platform/chrome: Introduce device tree hardware prober Chen-Yu Tsai
2024-09-04 10:08 ` Tzung-Bi Shih [this message]
2024-09-05 3:52 ` Chen-Yu Tsai
2024-09-05 4:34 ` Tzung-Bi Shih
2024-09-04 9:00 ` [PATCH v6 12/12] arm64: dts: mediatek: mt8173-elm-hana: Mark touchscreens and trackpads as fail Chen-Yu Tsai
2024-09-04 17:19 ` (subset) [PATCH v6 00/12] platform/chrome: Introduce DT hardware prober Mark Brown
2024-09-07 16:58 ` Wolfram Sang
2024-09-09 3:24 ` Chen-Yu Tsai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Ztgxlmhnkn7NVC81@google.com \
--to=tzungbi@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=bleung@chromium.org \
--cc=broonie@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=jikos@kernel.org \
--cc=johan@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh@kernel.org \
--cc=saravanak@google.com \
--cc=wenst@chromium.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).