From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, Sanket.Goswami@amd.com,
Patil.Reddy@amd.com
Subject: Re: [PATCH v6 4/8] i2c: amd-asf: Add ACPI support for AMD ASF Controller
Date: Fri, 20 Sep 2024 19:27:58 +0300 [thread overview]
Message-ID: <Zu2ijgbG-qfehYwM@smile.fi.intel.com> (raw)
In-Reply-To: <20240919175913.1895670-5-Shyam-sundar.S-k@amd.com>
On Thu, Sep 19, 2024 at 11:29:09PM +0530, Shyam Sundar S K wrote:
> The AMD ASF controller is presented to the operating system as an ACPI
> device. The AMD ASF driver can use ACPI to obtain information about the
> ASF controller's attributes, such as the ASF address space and interrupt
> number, and to handle ASF interrupts.
>
> Currently, the piix4 driver assumes that a specific port address is
> designated for AUX operations. However, with the introduction of ASF, the
> same port address may also be used by the ASF controller. Therefore, a
> check needs to be added to ensure that if ASF is advertised and enabled in
> ACPI, the AUX port should not be configured.
Okay,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-20 16:28 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-19 17:59 [PATCH v6 0/8] Introduce initial AMD ASF Controller driver support Shyam Sundar S K
2024-09-19 17:59 ` [PATCH v6 1/8] i2c: piix4: Change the parameter list of piix4_transaction function Shyam Sundar S K
2024-09-19 17:59 ` [PATCH v6 2/8] i2c: piix4: Move i2c_piix4 macros and structures to common header Shyam Sundar S K
2024-09-19 19:51 ` Andy Shevchenko
2024-09-19 17:59 ` [PATCH v6 3/8] i2c: piix4: Export i2c_piix4 driver functions as library Shyam Sundar S K
2024-09-20 16:24 ` Andy Shevchenko
2024-09-19 17:59 ` [PATCH v6 4/8] i2c: amd-asf: Add ACPI support for AMD ASF Controller Shyam Sundar S K
2024-09-20 16:27 ` Andy Shevchenko [this message]
2024-09-19 17:59 ` [PATCH v6 5/8] i2c: amd-asf: Add i2c_algorithm operations to support AMD ASF with SMBus Shyam Sundar S K
2024-09-20 17:39 ` Andy Shevchenko
2024-09-19 17:59 ` [PATCH v6 6/8] i2c: amd-asf: Add routine to handle the ASF slave process Shyam Sundar S K
2024-09-20 17:57 ` Andy Shevchenko
2024-09-19 17:59 ` [PATCH v6 7/8] i2c: amd-asf: Clear remote IRR bit to get successive interrupt Shyam Sundar S K
2024-09-20 17:59 ` Andy Shevchenko
2024-09-19 17:59 ` [PATCH v6 8/8] MAINTAINERS: Add AMD ASF driver entry Shyam Sundar S K
2024-09-20 15:06 ` Andy Shevchenko
2024-09-23 7:31 ` Shyam Sundar S K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zu2ijgbG-qfehYwM@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Patil.Reddy@amd.com \
--cc=Sanket.Goswami@amd.com \
--cc=Shyam-sundar.S-k@amd.com \
--cc=andi.shyti@kernel.org \
--cc=jdelvare@suse.com \
--cc=linux-i2c@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox