From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: linux-i2c@vger.kernel.org,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Jinjie Ruan <ruanjinjie@huawei.com>,
Mukesh Kumar Savaliya <quic_msavaliy@quicinc.com>,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] i2c: qcom-geni: Keep comment why interrupts start disabled
Date: Mon, 16 Sep 2024 15:39:03 +0200 [thread overview]
Message-ID: <Zug09yHONEFdGjav@shikoro> (raw)
In-Reply-To: <rezzwxrahok257tz35sxawqodn5sktkgxfokhmhdlrm2o4624p@agqoixuxg3md>
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
> Thanks for the patch! However, I wouldn’t typically consider this
> a fix, and I don’t think it would qualify for stable release
> inclusion.
Okay, I agree.
> That said, I agree that a comment should be added back. The original
> comment no longer fits as well as it did before. A more
> appropriate comment would be:
>
> /*
> * Do not enable interrupts by default to allow the system to enter
> * low-power mode. The driver will explicitly enable interrupts when
> * needed using enable_irq().
> */
>
> Does it make sense?
Frankly, I think this is too detailed, we can't have kernel driver 101
in each and every driver. But I will happily stand back if you insist
because we are entering a bike-shedding area. My proposal would be:
/* Keep interrupts disabled initially to allow for low-power modes */
Chose what you prefer!
Happy hacking,
Wolfram
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-09-16 13:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-16 12:15 [PATCH] i2c: qcom-geni: Keep comment why interrupts start disabled Wolfram Sang
2024-09-16 12:53 ` Andi Shyti
2024-09-16 13:39 ` Wolfram Sang [this message]
2024-09-16 14:06 ` Andi Shyti
2024-09-17 7:15 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zug09yHONEFdGjav@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=quic_msavaliy@quicinc.com \
--cc=ruanjinjie@huawei.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox