From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Michael Wu <michael.wu@kneron.us>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
linux-i2c@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
Morgan Chang <morgan.chang@kneron.us>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: designware: determine HS tHIGH and tLOW based on HW paramters
Date: Wed, 25 Sep 2024 12:21:20 +0300 [thread overview]
Message-ID: <ZvPWEFWk_MG5SsCg@smile.fi.intel.com> (raw)
In-Reply-To: <ZvPU2ZEG_8UV3FzF@smile.fi.intel.com>
On Wed, Sep 25, 2024 at 12:16:10PM +0300, Andy Shevchenko wrote:
> On Wed, Sep 25, 2024 at 04:04:30PM +0800, Michael Wu wrote:
...
> > + * @bus_loading: for high speed mode, the bus loading affects the high and low
> > + * pulse width of SCL
>
> This is bad naming, better is bus_capacitance.
Even more specific bus_capacitance_pf as we usually add physical units to the
variable names, so we immediately understand from the code the order of
numbers and their physical meanings.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-25 9:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 8:04 [PATCH 0/2] Compute HS HCNT and LCNT based on HW parameters Michael Wu
2024-09-25 8:04 ` [PATCH 1/2] i2c: designware: determine HS tHIGH and tLOW based on HW paramters Michael Wu
2024-09-25 9:16 ` Andy Shevchenko
2024-09-25 9:21 ` Andy Shevchenko [this message]
2024-09-26 8:45 ` Michael Wu
2024-09-26 12:18 ` Andy Shevchenko
2024-09-26 13:50 ` Krzysztof Kozlowski
2024-09-26 14:09 ` Andy Shevchenko
2024-09-25 10:58 ` Jarkko Nikula
2024-09-25 11:02 ` Andy Shevchenko
2024-09-26 9:11 ` Michael Wu
2024-09-25 11:33 ` Krzysztof Kozlowski
2024-09-27 13:41 ` kernel test robot
2024-09-25 8:04 ` [PATCH 2/2] dt-bindings: i2c: snps,designware-i2c: add bus-loading and clk-freq-optimized Michael Wu
2024-09-25 11:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvPWEFWk_MG5SsCg@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.wu@kneron.us \
--cc=mika.westerberg@linux.intel.com \
--cc=morgan.chang@kneron.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).