From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Michael Wu <michael.wu@kneron.us>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>,
linux-i2c@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
Morgan Chang <morgan.chang@kneron.us>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] i2c: designware: determine HS tHIGH and tLOW based on HW paramters
Date: Wed, 25 Sep 2024 14:02:40 +0300 [thread overview]
Message-ID: <ZvPt0NLoTJJwwjmA@smile.fi.intel.com> (raw)
In-Reply-To: <90f64539-3092-4d3b-bdf2-c6af51e32fdc@linux.intel.com>
On Wed, Sep 25, 2024 at 01:58:27PM +0300, Jarkko Nikula wrote:
> On 9/25/24 11:04 AM, Michael Wu wrote:
...
> Also i2c_dw_parse_of() sounds too generic and may lead to think all and only
> device tree related parameters are parsed here.
We already have a common (designware specific) function for this. the parsing
should be done as the part of that existing function. I.o.w. the existing just
needs to be extended for these two new properties.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-25 11:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-25 8:04 [PATCH 0/2] Compute HS HCNT and LCNT based on HW parameters Michael Wu
2024-09-25 8:04 ` [PATCH 1/2] i2c: designware: determine HS tHIGH and tLOW based on HW paramters Michael Wu
2024-09-25 9:16 ` Andy Shevchenko
2024-09-25 9:21 ` Andy Shevchenko
2024-09-26 8:45 ` Michael Wu
2024-09-26 12:18 ` Andy Shevchenko
2024-09-26 13:50 ` Krzysztof Kozlowski
2024-09-26 14:09 ` Andy Shevchenko
2024-09-25 10:58 ` Jarkko Nikula
2024-09-25 11:02 ` Andy Shevchenko [this message]
2024-09-26 9:11 ` Michael Wu
2024-09-25 11:33 ` Krzysztof Kozlowski
2024-09-27 13:41 ` kernel test robot
2024-09-25 8:04 ` [PATCH 2/2] dt-bindings: i2c: snps,designware-i2c: add bus-loading and clk-freq-optimized Michael Wu
2024-09-25 11:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZvPt0NLoTJJwwjmA@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.wu@kneron.us \
--cc=mika.westerberg@linux.intel.com \
--cc=morgan.chang@kneron.us \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).