From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>
Cc: Andi Shyti <andi.shyti@kernel.org>, Peter Rosin <peda@axentia.se>,
linux-i2c@vger.kernel.org
Subject: Re: [PATCH] i2c: Switch back to struct platform_driver::remove()
Date: Tue, 1 Oct 2024 10:40:42 +0200 [thread overview]
Message-ID: <Zvu1ijtQF30IScM5@shikoro> (raw)
In-Reply-To: <fde732497283c2a4b079731a84be583eafcdc781.1727537108.git.ukleinek@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]
On Sun, Sep 29, 2024 at 09:21:57AM +0200, Uwe Kleine-König wrote:
> After commit 0edb555a65d1 ("platform: Make platform_driver::remove()
> return void") .remove() is (again) the right callback to implement for
> platform drivers.
>
> Convert all platform drivers below drivers/i2c to use .remove(), with
> the eventual goal to drop struct platform_driver::remove_new(). As
> .remove() and .remove_new() have the same prototypes, conversion is done
> by just changing the structure member name in the driver initializer.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Hello,
>
> given the simplicity of the individual changes I do this all in a single
> patch. Please tell and I will happily split it.
I think one patch is perfect.
> I based this on Fridays's next, feel free to drop changes that result in
> a conflict when you come around to apply this. I'll care for the fallout
> at a later time then. (Having said that, if you use b4 am -3 and git am
> -3, there should be hardly any conflict.)
On rc1 and Andi's current i2c-host-next, this works without conflicts.
> Note I didn't Cc: all the individual driver maintainers to not trigger
> sending limits and spam filters.
Perfect again IMO.
Andi, do you want to take it? This is a typical after-rc1-cleanup patch,
so it should be applied soon for testing and send to Linus for rc2.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-10-01 8:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 7:21 [PATCH] i2c: Switch back to struct platform_driver::remove() Uwe Kleine-König
2024-10-01 8:40 ` Wolfram Sang [this message]
2024-10-02 9:11 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zvu1ijtQF30IScM5@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=peda@axentia.se \
--cc=u.kleine-koenig@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox