Re: [PATCH v6 2/4] i2c: npcm: Modify the client address assignment

Andy Shevchenko
2024-10-11T13:58:36Z

On Fri, Oct 11, 2024 at 09:44:42PM +0800, Tyrone Ting wrote:
> > On Fri, Oct 11, 2024 at 01:52:29PM +0800, Tyrone Ting wrote:

...

> > > + if (bus->dest_addr & I2C_M_RD)
> >
> > Redundant.
>
> Just to double check. Is the code "if (bus->dest_addr & I2C_M_RD)" redundant?

Yes.

> > > + bus->dest_addr &= ~I2C_M_RD;

--
With Best Regards,
Andy Shevchenko