From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Liu Peibao <loven.liu@jaguarmicro.com>
Cc: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Jan Dabros <jsd@semihalf.com>, Andi Shyti <andi.shyti@kernel.org>,
"xiaowu . ding" <xiaowu.ding@jaguarmicro.com>,
Angus Chen <angus.chen@jaguarmicro.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND TO CC MAILLIST] i2c: designware: fix master holding SCL low when I2C_DYNAMIC_TAR_UPDATE not set
Date: Fri, 1 Nov 2024 10:44:29 +0200 [thread overview]
Message-ID: <ZySU7bEvct4_FbBX@smile.fi.intel.com> (raw)
In-Reply-To: <20241101081243.1230797-1-loven.liu@jaguarmicro.com>
On Fri, Nov 01, 2024 at 04:12:43PM +0800, Liu Peibao wrote:
> When Tx FIFO empty and last command with no STOP bit set, the master
> holds SCL low. If I2C_DYNAMIC_TAR_UPDATE is not set, BIT(13) MST_ON_HOLD
> of IC_RAW_INTR_STAT is not Enabled, causing the __i2c_dw_disable()
> timeout. This is quiet similar as commit 2409205acd3c ("i2c: designware:
> fix __i2c_dw_disable() in case master is holding SCL low") mentioned.
> Check BIT(7) MST_HOLD_TX_FIFO_EMPTY in IC_STATUS also which is available
> when IC_STAT_FOR_CLK_STRETCH is set.
Who are those people? Why Angus Chen is not a committer of the change?
Please, consult with the Submitting Patches documentation to clarify on these
tags.
Also, sounds to me that Fixes tag is needed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-11-01 8:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-01 8:12 [PATCH RESEND TO CC MAILLIST] i2c: designware: fix master holding SCL low when I2C_DYNAMIC_TAR_UPDATE not set Liu Peibao
2024-11-01 8:44 ` Andy Shevchenko [this message]
2024-11-01 10:18 ` Liu Peibao
2024-11-05 20:30 ` Andi Shyti
2024-11-06 7:27 ` Liu Peibao
2024-11-06 9:46 ` Andi Shyti
2024-11-06 10:09 ` Liu Peibao
2024-11-06 11:53 ` Jarkko Nikula
2024-11-06 23:07 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZySU7bEvct4_FbBX@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=angus.chen@jaguarmicro.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=loven.liu@jaguarmicro.com \
--cc=mika.westerberg@linux.intel.com \
--cc=xiaowu.ding@jaguarmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox