From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Andi Shyti <andi.shyti@kernel.org>
Cc: Yang Yingliang <yangyingliang@huaweicloud.com>,
peda@axentia.se, farouk.bouabid@cherry.de,
linux-i2c@vger.kernel.org, yangyingliang@huawei.com,
bobo.shaobowang@huawei.com
Subject: Re: [PATCH] i2c: muxes: Fix return value check in mule_i2c_mux_probe()
Date: Mon, 4 Nov 2024 12:56:52 +0200 [thread overview]
Message-ID: <ZyiodI3tFe9xbLVv@shikoro> (raw)
In-Reply-To: <yq3ncphzoexlecxqqo5y4qhepc6u7sks4glb4n6jzlytynuylk@ndxwo3twzl3j>
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
On Thu, Oct 31, 2024 at 01:09:17PM +0100, Andi Shyti wrote:
> Hi Yang,
>
> On Sat, Oct 26, 2024 at 11:09:42AM +0800, Yang Yingliang wrote:
> > From: Yang Yingliang <yangyingliang@huawei.com>
> >
> > If dev_get_regmap() fails, it returns NULL pointer not ERR_PTR(),
> > replace IS_ERR() with NULL pointer check, and return -ENODEV.
> >
> > Fixes: d0f8e97866bf ("i2c: muxes: add support for tsd,mule-i2c multiplexer")
> > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
>
> merged to i2c/i2c-host-fixes.
I'd like an ack from Farouk here. In general, -ENODEV makes the driver
core sliently fail (ok, we have a printout but still). But not getting
the regmap sounds like a real error to me. I'd suggest -ENOENT or
something. But maybe this mux is a special case, Farouk should know.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2024-11-04 10:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-26 3:09 [PATCH] i2c: muxes: Fix return value check in mule_i2c_mux_probe() Yang Yingliang
2024-10-31 12:09 ` Andi Shyti
2024-11-04 10:56 ` Wolfram Sang [this message]
2024-11-04 12:55 ` Farouk Bouabid
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZyiodI3tFe9xbLVv@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=bobo.shaobowang@huawei.com \
--cc=farouk.bouabid@cherry.de \
--cc=linux-i2c@vger.kernel.org \
--cc=peda@axentia.se \
--cc=yangyingliang@huawei.com \
--cc=yangyingliang@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox