From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Igor Pylypiv <ipylypiv@google.com>
Cc: Jean Delvare <jdelvare@suse.de>,
Andi Shyti <andi.shyti@kernel.org>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] i2c: dev: Fix memory leak when underlying adapter does not support I2C
Date: Thu, 14 Nov 2024 11:45:45 +0100 [thread overview]
Message-ID: <ZzXU2YSK56C8bqp4@shikoro> (raw)
In-Reply-To: <20241108001542.255155-1-ipylypiv@google.com>
[-- Attachment #1: Type: text/plain, Size: 603 bytes --]
On Fri, Nov 08, 2024 at 12:15:42AM +0000, Igor Pylypiv wrote:
> Early return in i2cdev_ioctl_rdwr() failed to free the memory allocated
> by the caller. Move freeing the memory to the function where it has been
> allocated to prevent similar leaks in the future.
>
> Fixes: 97ca843f6ad3 ("i2c: dev: Check for I2C_FUNC_I2C before calling i2c_transfer")
> Signed-off-by: Igor Pylypiv <ipylypiv@google.com>
Applied to for-next, thanks!
> + if (data_ptrs == NULL)
I changed this to '!data_ptrs' while here because most of the file does
it like this. And checkpatch and I prefer it, too.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2024-11-14 10:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 0:15 [PATCH v2] i2c: dev: Fix memory leak when underlying adapter does not support I2C Igor Pylypiv
2024-11-14 10:45 ` Wolfram Sang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZzXU2YSK56C8bqp4@shikoro \
--to=wsa+renesas@sang-engineering.com \
--cc=andi.shyti@kernel.org \
--cc=ipylypiv@google.com \
--cc=jdelvare@suse.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox