From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com [209.85.167.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00DC9305966 for ; Wed, 15 Oct 2025 23:32:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760571142; cv=none; b=ryJ8Tj0bkTHA3igaxSntNU9GK/sg88yQrpmggfJRK6GyJf6SwGm4IiFGzavB2N+Q+NrvDSqnRT3ULLN52Fatl5r0lRe4vLEuxAKOfnFJrB9bsb3hXp7Zq9A4Nl32eX8Cg9AieLpPpHGDYnZLl9EfuXRfzhtpxPPVk/6ARv/cuP0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760571142; c=relaxed/simple; bh=E+hpu09ROQFdd1Em57oWayPsfVLzQBtFlkrFf6LFmYU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=fOwmE84QjQL9Afk+qVF56JpjbYlM8EasehN59mxhLlEqzm3uAG8UUIFpWgAymicDvnyTmRH5uLgLqBroHLKdrVw6IrR1PN/S8IRswJuZIbKbBH7l/1lhYDHeZBH2uxMwmQPNQDH+jRkuOSsb5BLmCkVyW3h3OAY12OwhmQGuu8I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=KpVCN8fg; arc=none smtp.client-ip=209.85.167.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="KpVCN8fg" Received: by mail-lf1-f48.google.com with SMTP id 2adb3069b0e04-58b002614d2so23583e87.2 for ; Wed, 15 Oct 2025 16:32:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1760571138; x=1761175938; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=bpPxh0gcuqDsiBGhGT8nfnZ05AHmMsVAlwdJ8sk5caw=; b=KpVCN8fg0eKg+zdhFi9pvlUG710HlDdM9sObq1jqHgTkTO3Ygjm4sKpnY8I63B2aaI QX6BGdY0/A/RfprOLYqyuaCrIfVE2N+tpQZ89WJ7BOJUuKOFqBQt3LoXpr5plqKcIk/v YBZ5vpfrSOTY4V4JlM2uEqtny6WW9AKCHbxUOniJliz3Aa/4cMgkFk2DUpNuLnUwmc/G l1mgpnWyH9J4UcRAy9M8POCKBihBmKBAkG4hqv3BiFYxV0VG6J5sRThHoRwuMZnqiCWF j9N6eHE6pf/KM/iuFgf+5bGbCUFiOAhyafIXlYEtgmmRXOkYP7cwAEpSoeoO6jFcx0Ha OVZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760571138; x=1761175938; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=bpPxh0gcuqDsiBGhGT8nfnZ05AHmMsVAlwdJ8sk5caw=; b=S+aYqeP8SlMldxX0Y1bXyTNHJc//kNQWiuFF79nUZV53n0SDwfppVrYA8fPifWgzuk g7kFm9x7i6l31wYp4HAKBZCaBYdkzMVTzEYI17cYJ3qHrTHWCaA5uc8Wpv9AYPDMaSO7 +BcqnBuKqiUiffdNZyUrrGehzKWEdYSjnCIEjiKqVBumDLdw52WxpV6ltRrwhbmOnn3M tB1NkjCE8eqC4mVXVClhxF4+86yAV/o7wPb16FDBQIRur6YCqXE5qyTWg9RfVpsd4oFm Y137hDjFvg4X1/OWBtwCd+dI2m9pYJnYO781Z/85XorOJh3Zr6SyZg14KW3MoDsxWEaY 5WgQ== X-Gm-Message-State: AOJu0Yw8gTmt7bx0TCEZRtq/68SGJFucMiN9Y6z/KnvvNKlfc9EfIbNJ Pf+avcCTmN9dYvYhml5ebh96Np3qNcGAE0S+P3ESWjdsz+o6mPx3t6RwFvO56wpKynY= X-Gm-Gg: ASbGnct6Touds/TIhKj8xV3CCwrPnWqnWWVNKOsOFmcunhQhRDHFdMZ9Jmc2MYtwVuz xLwy9IC30oKemxAXRs8qjYYNyx3nDVwIRWCJV/femXGcgNjIZPyN6i71oryeU93KAHBc663C2sw OXEUncb0KSr+mhYqLWAx8U6pMUMrD/TlcbKc7/fp/Y6D2+k40mQKiTUvtITU8AvQmuoGlohLl1a UFyleN3lb0eM9jUktXUjUfJbT9+CXgZxcForcgx2Qu2Sv863RskMBAZAeiFS2qxMVqU29ESkPS2 YajvwmXVSNx7CAEA6RQQQAVY8z1eB9zKHdLQ6H1lK2Cak2o8Pd/8YzFOhD1TAP834Pml1MfUS2F gFWwRaDe/e/0wwK5MYNMsR5XlZuxxMPXxBikmtidTCcWO8ATqEF47vuxL8bUq7akCfJa/rcN0L7 D+5Q4Z/iQM2+DYLaFt+SiUU44RXQ0oCaRX4/+cxX8IOK6fPv6O9D5lLl+t6TM= X-Google-Smtp-Source: AGHT+IFhmCfc/iqqM/lx8OD9acToPRRAMIUni22wMDWOAc8jc/Nu4v4J+9jAJJcyPXA90FdVyjEthA== X-Received: by 2002:a05:6512:682:b0:57d:c562:1f78 with SMTP id 2adb3069b0e04-5906d8ed17dmr5015764e87.5.1760571138323; Wed, 15 Oct 2025 16:32:18 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3762e77cc6asm50763801fa.2.2025.10.15.16.32.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Oct 2025 16:32:17 -0700 (PDT) Message-ID: Date: Thu, 16 Oct 2025 02:32:15 +0300 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] dt-bindings: media: camss: Add qcom,kaanapali-camss binding To: Bryan O'Donoghue , Hangxiang Ma , Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Mauro Carvalho Chehab Cc: linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com, Jingyi Wang , Atiya Kailany References: <20251014-add-support-for-camss-on-kaanapali-v2-0-f5745ba2dff9@oss.qualcomm.com> <20251014-add-support-for-camss-on-kaanapali-v2-2-f5745ba2dff9@oss.qualcomm.com> <0b6c157a-3d8d-4251-a704-31f8369f6a4e@linaro.org> From: Vladimir Zapolskiy In-Reply-To: <0b6c157a-3d8d-4251-a704-31f8369f6a4e@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 10/16/25 00:43, Bryan O'Donoghue wrote: > On 15/10/2025 20:45, Vladimir Zapolskiy wrote: >>> +  power-domains: >>> +    items: >>> +      - description: >>> +          TFE0 GDSC - Thin Front End, Global Distributed Switch >>> Controller. >>> +      - description: >>> +          TFE1 GDSC - Thin Front End, Global Distributed Switch >>> Controller. >>> +      - description: >>> +          TFE2 GDSC - Thin Front End, Global Distributed Switch >>> Controller. >>> +      - description: >>> +          Titan GDSC - Titan ISP Block Global Distributed Switch >>> Controller. >>> + >>> +  power-domain-names: >>> +    items: >>> +      - const: tfe0 >>> +      - const: tfe1 >>> +      - const: tfe2 >> >> Please remove all 'tfeX' power domains, they are not going to be utilized >> any time soon. >> >> When 'power-domains' list is just a single Titan GDSC, 'power-domain-names' >> property is not needed. > > Each one of these TFEs powers an individually power-collapsible TFEs. > > This is also so with the other xFE power-domains on previous SoC > generations. This is false, for instance there is no management of SFEx power domains in SM8550 or X1E80100 CAMSS in the upstrem, neither there is no management of SBI, IPE, BPS, CPP and so on GDSC power domans given by CAMCCs. TFEx is no more special, if it's unused, then it should not be added. > > You'll need the TFEx power-domain to process any data on TFEx with the > 'lite' versions being tied to the TOP GDSC. When it is needed, the documentation will be updated accordingly, right now it is unknown what a data processing on TFEx looks like, it might happen that there will be separate device tree nodes for TFEx. TFEx power domains shall be removed right now, unti; a usecase in the upstream CAMSS appears to use them, I haven't seen such code at the moment. -- Best wishes, Vladimir