From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-i2c@vger.kernel.org, Wolfram Sang <wsa@kernel.org>,
John Stultz <john.stultz@linaro.org>
Subject: Re: [PATCH] i2c: designware: Fix bus speed in !CONFIG_ACPI case
Date: Tue, 23 Jun 2020 13:47:37 +0300 [thread overview]
Message-ID: <a153f12b-9135-17fa-d9cc-08498d0cf0b1@linux.intel.com> (raw)
In-Reply-To: <20200623084710.GQ2428291@smile.fi.intel.com>
On 6/23/20 11:47 AM, Andy Shevchenko wrote:
> On Tue, Jun 23, 2020 at 11:46:35AM +0300, Andy Shevchenko wrote:
>> On Tue, Jun 23, 2020 at 11:31:13AM +0300, Jarkko Nikula wrote:
>>> John Stultz reported that commit f9288fcc5c615 ("i2c: designware: Move
>>> ACPI parts into common module") caused a regression on the HiKey board
>>> where adv7511 HDMI bridge driver wasn't probing anymore due the I2C bus
>>> failed to start.
>>>
>>> It seems the change caused the bus speed being zero when CONFIG_ACPI
>>> not set and neither speed based on "clock-frequency" device property or
>>> default fast mode is set.
>>>
>>> Fix this by moving bus speed setting back to dw_i2c_plat_probe() and let
>>> the i2c_dw_acpi_adjust_bus_speed() adjust only speed from ACPI.
>>
>> I have slightly different idea, I'll send a patch soon after testing.
>
> Note, your patch breaks PCI case.
>
Ah, indeed. So please ignore my patch.
--
Jarkko
next prev parent reply other threads:[~2020-06-23 10:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-23 8:31 [PATCH] i2c: designware: Fix bus speed in !CONFIG_ACPI case Jarkko Nikula
2020-06-23 8:46 ` Andy Shevchenko
2020-06-23 8:47 ` Andy Shevchenko
2020-06-23 10:47 ` Jarkko Nikula [this message]
2020-06-23 9:15 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a153f12b-9135-17fa-d9cc-08498d0cf0b1@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=john.stultz@linaro.org \
--cc=linux-i2c@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox