From: Michal Simek <michal.simek@xilinx.com>
To: Wolfram Sang <wsa@the-dreams.de>, shubhrajyoti.datta@gmail.com
Cc: linux-i2c@vger.kernel.org, michal.simek@xilinx.com,
linux-kernel@vger.kernel.org,
Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Subject: Re: [PATCH] i2c: xiic: Make the start and the byte count write atomic
Date: Fri, 7 Sep 2018 08:02:50 +0200 [thread overview]
Message-ID: <a26d5aa1-de79-c881-da3c-5be67d1fc4a4@xilinx.com> (raw)
In-Reply-To: <20180906185201.GG8607@kunai>
On 6.9.2018 20:52, Wolfram Sang wrote:
> On Mon, Sep 03, 2018 at 03:11:11PM +0530, shubhrajyoti.datta@gmail.com wrote:
>> From: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>>
>> Disable interrupts while configuring the transfer and enable them back.
>>
>> We have below as the programming sequence
>> 1. start and slave address
>> 2. byte count and stop
>>
>> In some customer platform there was a lot of interrupts between 1 and 2
>> and after slave address (around 7 clock cyles) if 2 is not executed
>> then the transaction is nacked.
>>
>> To fix this case make the 2 writes atomic.
>>
>> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>
> Added a newline for better readability, added the stable tag and applied
> to for-current, thanks!
>
> BTW we have no maintainer for this driver. Would you or Michal be
> interested in doing that? I don't maintain the whole driver directory
> anymore.
Normally we do handle it via Zynq fragment to have single point of
contact. I have sent a patch for that. Please take it via i2c tree.
Thanks,
Michal
prev parent reply other threads:[~2018-09-07 6:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-03 9:41 [PATCH] i2c: xiic: Make the start and the byte count write atomic shubhrajyoti.datta
2018-09-04 16:11 ` Wolfram Sang
2018-09-06 7:08 ` Shubhrajyoti Datta
2018-09-06 18:52 ` Wolfram Sang
2018-09-07 6:02 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a26d5aa1-de79-c881-da3c-5be67d1fc4a4@xilinx.com \
--to=michal.simek@xilinx.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shubhrajyoti.datta@gmail.com \
--cc=shubhrajyoti.datta@xilinx.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).