From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
To: "Liu Kimriver/刘金河" <kimriver.liu@siengine.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: "mika.westerberg@linux.intel.com"
<mika.westerberg@linux.intel.com>,
"jsd@semihalf.com" <jsd@semihalf.com>,
"andi.shyti@kernel.org" <andi.shyti@kernel.org>,
"linux-i2c@vger.kernel.org" <linux-i2c@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v8] i2c: designware: fix master is holding SCL low while ENABLE bit is disabled
Date: Tue, 10 Sep 2024 14:20:06 +0300 [thread overview]
Message-ID: <a2de8e23-d2a0-4585-8b51-2144801eeff8@linux.intel.com> (raw)
In-Reply-To: <743187d2fde54a9ebf86d42e29eadfb4@siengine.com>
On 9/10/24 12:38 PM, Liu Kimriver/刘金河 wrote:
> Hi Andy,
>
>> -----Original Message-----
>> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> Sent: 2024年9月10日 17:03
>> To: Liu Kimriver/刘金河 <kimriver.liu@siengine.com>
>> Cc: jarkko.nikula@linux.intel.com; mika.westerberg@linux.intel.com; jsd@semihalf.com; andi.shyti@kernel.org; linux-i2c@vger.kernel.org; linux-kernel@vger.kernel.org
>> Subject: Re: [PATCH v8] i2c: designware: fix master is holding SCL low while ENABLE bit is disabled
>
>> On Tue, Sep 10, 2024 at 02:13:09PM +0800, Kimriver Liu wrote:
>>> It was observed issuing ABORT bit(IC_ENABLE[1]) will not work when
>>
>> "...observed that issuing..."
>> ...bit (..."
>
>
>>> IC_ENABLE is already disabled.
>>>
>>> Check if ENABLE bit(IC_ENABLE[0]) is disabled when the master is
>
>> "...bit (..."
>> master --> controller
>
> Update it in V9
>
Please add back also kernel errors that are shown when the issue occurs.
I saw those mentioned in the commit log in some earlier version of the
patch.
Those may help googling the solution (i.e. this patch) if somebody sees
similar error on their HW.
next prev parent reply other threads:[~2024-09-10 11:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 6:13 [PATCH v8] i2c: designware: fix master is holding SCL low while ENABLE bit is disabled Kimriver Liu
2024-09-10 9:02 ` Jarkko Nikula
2024-09-10 9:53 ` Liu Kimriver/刘金河
2024-09-10 9:02 ` Andy Shevchenko
2024-09-10 9:38 ` Liu Kimriver/刘金河
2024-09-10 10:45 ` Andy Shevchenko
2024-09-10 11:43 ` Liu Kimriver/刘金河
2024-09-10 11:59 ` Andy Shevchenko
2024-09-11 1:37 ` Liu Kimriver/刘金河
2024-09-11 14:42 ` Andy Shevchenko
2024-09-10 11:20 ` Jarkko Nikula [this message]
2024-09-10 11:54 ` Liu Kimriver/刘金河
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2de8e23-d2a0-4585-8b51-2144801eeff8@linux.intel.com \
--to=jarkko.nikula@linux.intel.com \
--cc=andi.shyti@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jsd@semihalf.com \
--cc=kimriver.liu@siengine.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox