From: Oliver Neukum <oneukum@suse.com>
To: Ye Xiang <xiang.ye@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Matthias Kaehlcke <mka@chromium.org>, Lee Jones <lee@kernel.org>,
Wolfram Sang <wsa@kernel.org>, Tyrone Ting <kfting@nuvoton.com>,
Mark Brown <broonie@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Marc Zyngier <maz@kernel.org>,
Bartosz Golaszewski <brgl@bgdev.pl>,
linux-usb@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
linux-gpio@vger.kernel.org
Cc: srinivas.pandruvada@intel.com, heikki.krogerus@linux.intel.com,
andriy.shevchenko@linux.intel.com, sakari.ailus@linux.intel.com,
zhifeng.wang@intel.com, wentong.wu@intel.com,
lixu.zhang@intel.com
Subject: Re: [PATCH v8 5/6] i2c: Add support for Intel LJCA USB I2C driver
Date: Mon, 22 May 2023 11:50:03 +0200 [thread overview]
Message-ID: <a33654a6-71e0-07ac-a612-b1f7aedebb36@suse.com> (raw)
In-Reply-To: <20230511175844.185070-6-xiang.ye@intel.com>
On 11.05.23 19:58, Ye Xiang wrote:
> Implements the I2C function of Intel USB-I2C/GPIO/SPI adapter device
> named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA I2c
> module with specific protocol through interfaces exported by LJCA
> USB driver.
> +/* I2C Transfer */
> +struct i2c_xfer {
> + u8 id;
> + u8 slave;
> + u16 flag; /* speed, 8/16bit addr, addr increase, etc */
> + u16 addr;
> + u16 len;
> + u8 data[];
> +} __packed;
Where is this needed?
Why is it defined __packed, yet the internal endianness
is not declared?
Regards
Oliver
next prev parent reply other threads:[~2023-05-22 9:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 17:58 [PATCH v8 0/6] Add Intel LJCA device driver Ye Xiang
2023-05-11 17:58 ` [PATCH v8 1/6] usb: Add support for Intel LJCA device Ye Xiang
2023-05-22 9:21 ` Oliver Neukum
2023-06-20 7:39 ` Wu, Wentong
2023-06-20 12:11 ` Oliver Neukum
2023-05-11 17:58 ` [PATCH v8 2/6] usb: ljca: Add transport interfaces for sub-module drivers Ye Xiang
2023-05-22 9:36 ` Oliver Neukum
2023-05-11 17:58 ` [PATCH v8 3/6] Documentation: Add ABI doc for attributes of LJCA device Ye Xiang
2023-05-11 17:58 ` [PATCH v8 4/6] gpio: Add support for Intel LJCA USB GPIO driver Ye Xiang
2023-05-11 21:07 ` Linus Walleij
2023-06-20 7:00 ` Wu, Wentong
2023-05-15 15:49 ` Bartosz Golaszewski
2023-07-03 1:11 ` Wu, Wentong
2023-05-11 17:58 ` [PATCH v8 5/6] i2c: Add support for Intel LJCA USB I2C driver Ye Xiang
2023-05-22 9:50 ` Oliver Neukum [this message]
2023-06-20 6:57 ` Wu, Wentong
2023-05-11 17:58 ` [PATCH v8 6/6] spi: Add support for Intel LJCA USB SPI driver Ye Xiang
2023-05-12 4:18 ` Mark Brown
2023-06-20 6:47 ` Wu, Wentong
2023-06-20 11:39 ` Mark Brown
2023-05-13 8:50 ` [PATCH v8 0/6] Add Intel LJCA device driver Greg Kroah-Hartman
2023-06-20 8:10 ` Wu, Wentong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a33654a6-71e0-07ac-a612-b1f7aedebb36@suse.com \
--to=oneukum@suse.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=brgl@bgdev.pl \
--cc=broonie@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=kfting@nuvoton.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lixu.zhang@intel.com \
--cc=maz@kernel.org \
--cc=mka@chromium.org \
--cc=sakari.ailus@linux.intel.com \
--cc=srinivas.pandruvada@intel.com \
--cc=wentong.wu@intel.com \
--cc=wsa@kernel.org \
--cc=xiang.ye@intel.com \
--cc=zhifeng.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox