From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABCAA54789; Mon, 20 May 2024 13:41:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716212497; cv=none; b=h8vJ/eB6FqgOlaZ9Sd8szV7QRRuefh46fdlgt+U9l4S7QakPdLtiWrWr52JFXdQYy7VrP3GGirNEGjT6qkoFKtv55Uv24iwhrIQWR5KkF0XAEAPfOqQnr9T6WvKMB17mTxIusxSUNPwLl9k80G40slWLH1jbyM6hvv5NWXxKDGQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1716212497; c=relaxed/simple; bh=tDiANetDoW1pQLr/KuXUjU82Zacm1RZP8bbd93enBmw=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Oom3q+9BUtjhj80I2ihIfbAKX8cyQV079d1LW6NkMbYmeIJHe1lwmgPKknU5UtA2611F8aP8Bhsvv42xDkjLDU6v7pPaSVrHY/lWoUq9Cae6amgK8U4VUmCkrWov3JCh9OvL4whdOFp9t/e+e1/qQZHsPOatP3kzL3TCyHXrPL0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=dFQrREXY; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="dFQrREXY" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Disposition: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:From: Sender:Reply-To:Subject:Date:Message-ID:To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Content-Disposition: In-Reply-To:References; bh=GgIHxPkfIqu3jiSSto02RWnKkf1y+ggjPEgehOTqsBM=; b=dF QrREXY6vZiR7rSNZCz+DDVvWrxiUt1oPG78n7yje788+FHEnXJ8BmFIV88pJ3EShJ75hMA3r3TLPR g/B/4O20JEgiWctoXWmIif9WSIQ19NJQCr+vsSkqZ7w/ZOn5oc6QB0iG6OrImNMEQMDgbMHJZYtVQ UdZWtpTuGv2TuzE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1s93Gc-00FhSS-9z; Mon, 20 May 2024 15:41:30 +0200 Date: Mon, 20 May 2024 15:41:30 +0200 From: Andrew Lunn To: grygorii tertychnyi Cc: Markus Elfring , Grygorii Tertychnyi , bsp-development.geo@leica-geosystems.com, linux-i2c@vger.kernel.org, kernel-janitors@vger.kernel.org, Peter Korsgaard , Thomas Gleixner , LKML Subject: Re: [PATCH] i2c: ocores: set IACK bit after core is enabled Message-ID: References: <20240517191000.11390-1-grygorii.tertychnyi@leica-geosystems.com> <6eee1069-81ae-495a-850f-7f526006db8b@web.de> Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, May 20, 2024 at 03:30:43PM +0200, grygorii tertychnyi wrote: > On Sun, May 19, 2024 at 7:25 AM Markus Elfring wrote: > > > > … > > > Sometimes it causes failure for the very first message transfer, … > > > > Does such an information indicate the need for the tag “Fixes”? > > I'm not sure: the original initialization order was introduced by the > very first commit > 18f98b1e3147 ("[PATCH] i2c: New bus driver for the OpenCores I2C controller"). https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html It fixes a problem like an oops, a hang, data corruption, a real security issue, a hardware quirk, a build error (but not for things marked CONFIG_BROKEN), or some “oh, that’s not good” issue. Your description of the very first message transfer failing sounds like a data corruption? Using the commit which adds the driver is also fine, some bugs have been there all the time. Remember to add a Cc: stable@vger.kernel.org Andrew