From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Thomas Bonnefille <thomas.bonnefille@bootlin.com>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Jisheng Zhang <jszhang@kernel.org>, Guo Ren <guoren@kernel.org>,
Fu Wei <wefu@redhat.com>, Drew Fustini <dfustini@tenstorrent.com>,
Emil Renner Berthing <emil.renner.berthing@canonical.com>,
Conor Dooley <conor@kernel.org>
Cc: "Palmer Dabbelt" <palmer@dabbelt.com>,
"Albert Ou" <aou@eecs.berkeley.edu>,
"Paul Walmsley" <paul.walmsley@sifive.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Miquèl Raynal" <miquel.raynal@bootlin.com>,
linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org,
"Conor Dooley" <conor.dooley@microchip.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: i2c: dw: Document compatible thead,th1520-i2c
Date: Wed, 19 Jun 2024 09:39:46 +0200 [thread overview]
Message-ID: <a55524d8-40f0-44ba-a42f-c63a487ccb45@kernel.org> (raw)
In-Reply-To: <f427b28c-420b-4174-a670-70f626f8061e@linux.intel.com>
On 19/06/2024 08:40, Jarkko Nikula wrote:
> Hi
>
> On 6/18/24 10:42 AM, Thomas Bonnefille wrote:
>> Add documentation for compatible string thead,th1520-i2c which can be
>> used specifically for the TH1520 SoC.
>>
>> Signed-off-by: Thomas Bonnefille <thomas.bonnefille@bootlin.com>
>> Acked-by: Conor Dooley <conor.dooley@microchip.com>
>> ---
>> Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
>> index d9293c57f573..60035a787e5c 100644
>> --- a/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
>> +++ b/Documentation/devicetree/bindings/i2c/snps,designware-i2c.yaml
>> @@ -33,6 +33,10 @@ properties:
>> - const: snps,designware-i2c
>> - description: Baikal-T1 SoC System I2C controller
>> const: baikal,bt1-sys-i2c
>> + - description: T-HEAD TH1520 SoCs I2C controller
>> + items:
>> + - const: thead,th1520-i2c
>> + - const: snps,designware-i2c
>>
>
> Your comment below makes me thinking is this change needed? So is it
> enough to specify "snps,designware-i2c" for the compatible string in
> patch 2/3?
SoC specific compatible is always required (see writing bindings doc).
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-06-19 7:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 7:42 [PATCH v3 0/3] Add I2C support on TH1520 Thomas Bonnefille
2024-06-18 7:42 ` [PATCH v3 1/3] dt-bindings: i2c: dw: Document compatible thead,th1520-i2c Thomas Bonnefille
2024-06-19 6:40 ` Jarkko Nikula
2024-06-19 7:37 ` Icenowy Zheng
2024-06-19 7:39 ` Krzysztof Kozlowski [this message]
2024-06-19 13:42 ` Jarkko Nikula
2024-06-18 7:42 ` [PATCH v3 2/3] riscv: dts: thead: Add TH1520 I2C nodes Thomas Bonnefille
2024-06-25 21:30 ` Drew Fustini
2024-06-18 7:42 ` [PATCH v3 3/3] riscv: dts: thead: Enable I2C on the BeagleV-Ahead Thomas Bonnefille
2024-06-25 21:30 ` Drew Fustini
2024-07-21 22:47 ` Emil Renner Berthing
2024-06-25 21:28 ` [PATCH v3 0/3] Add I2C support on TH1520 Drew Fustini
2024-06-28 9:30 ` Andi Shyti
2024-06-28 10:49 ` Conor Dooley
2024-07-10 7:48 ` (subset) " Andi Shyti
2024-07-10 8:21 ` Krzysztof Kozlowski
2024-07-10 13:01 ` Andi Shyti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a55524d8-40f0-44ba-a42f-c63a487ccb45@kernel.org \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=conor@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dfustini@tenstorrent.com \
--cc=emil.renner.berthing@canonical.com \
--cc=guoren@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=jszhang@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
--cc=thomas.bonnefille@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).