From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 714782036E9 for ; Mon, 2 Dec 2024 14:04:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733148301; cv=none; b=QLXOW8wDa4Ur0m4ZxlxhARQvD1EP0iTelHUZvIvOWfdlv/Wt/tqx55pGFX63gVIaw7hHo+ZSWYAe/nJ57tx/QZ3Imy+FDa5UV3sN1lHiKW7e8sgaSUmjTHYOxwsC9wI92j9qfYP7VGnzIop6YvZlF2e5z0/+sWD2H0J5NhFH7Ek= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733148301; c=relaxed/simple; bh=aCYEkOOpOjkMmGmDP1MwOlRPzT0/3YQQiUfyUisKajQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=pvp3+WfI/4+YSgTHJW3qhILp8ms02sbbxtpNkiWS4Bt3r+QGgHsodOAWRfbxbaH43+V3sQblXtr5NqsB8PaHL3OKQlzLhN4jKJFiSQd1/AQ7r5OCBx784L166QAM/oBA4iqiHExFbMuUSyPV6K0mOxJSypoOMblkPkPj+lBOtos= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jIQhBeZ8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jIQhBeZ8" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4B28au9B030649 for ; Mon, 2 Dec 2024 14:04:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= obaOPszO5mGm/TOqEFLd2+ypX1a+TNEXvHr7XvUqJ7E=; b=jIQhBeZ8H2dDtMVf P7Kyqn6cy62AuXpsil62QSHvcfgIJ1S6nKJ6/tMk2uBDZyBq5Uy56+Tkfi6x05ne T5NEuTOKHslTq5ar6lKhsmzQKKs0G33w1DCW71BlTlZIbr4hzm0tvWmZOiPc1xOm E85bOxD8/ogLbbCykmzhPnvWzR6sGusHHNlAKeNHBzDoDDqNcY6JyGO/PTx6kkO2 ZviRNau3d5wEDrb53Y4q7glL6pqMVUUIV9SM0cZl1TFt6p7yxSoq7hLDftOoYB9k xJt/HgRzlV3qFMXZ9zE0cc28lVQtZE1vEGSvigc8PDu0HLOopyKDzZF7iV6dJk7n Tgu/ug== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 437t1gd2u8-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 02 Dec 2024 14:04:57 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-466cbd99b11so4942621cf.1 for ; Mon, 02 Dec 2024 06:04:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733148297; x=1733753097; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=obaOPszO5mGm/TOqEFLd2+ypX1a+TNEXvHr7XvUqJ7E=; b=MEno/xwm/oE8uM6EsKaJQoa11C8e4IkmcJn9WFijUjL7rxglzEwxa1AXClPBdiqMf2 60f1pUm+gHeiElT4lZYFVaiNu0hmQsy1dEvaYCntQ7hyPY+EQtQ416s7QC63HPRJ7wKh NLXHomsxnDbYOaE2N61IR/SsMOHk6+GEOF8rCerC3DWFTi7IMAGoKCYZ05OyXsWZcavP CCxQusxHIMBcyHiP8mqTRsroEn3pt1azMQk6gqx3wsjFH4A+hltmGRZAAvG0bUx7IQ6g WLTEyO+ODt1b/+zE3vb1vjmuM5B8wMb8jWOTD0PpO8Vp3g0frChqpbyFxqQdNUxAoPLN yp5Q== X-Forwarded-Encrypted: i=1; AJvYcCUty4nLVJRBAt8OprWp9YRP+6HvAjObS4YZAZ1xejIVkyZQm72wZx5B+fAknIO+U0cJvr7FyTKgwwA=@vger.kernel.org X-Gm-Message-State: AOJu0YxDjz8yQPiRcZOW4BQUqM4SaxzUpp9F2H1bLDiH6kRRZuAE62xD uO6t3gO1FyWZfP4K78yARlpuxtcaXH5NPfI3ztCPeO7RIZEvod6Tr7+eiSUDJdvLy3l1SLmB3Sq j2EwlFSJdNwa4kFPsLOhnv2+SpgxzAy7rcO3flmJA5K8ZTKiMp+6b4LplZNs= X-Gm-Gg: ASbGncsz2qLwoDHDdcmPEIncYWIpnOiYTDWZ/fCb3441X3Sat8ohe2QvQ6ZAdvW5Xco 5RdA9OePG1JkpozL5csz63fMTBdNC/WO81u6mtI1laqIybbdEmrWnYbvyoqsN44jKpjj3/ljLQ3 owBh1fzdAV1jeXXf+0xkeORLGK7z8t6dTOr32sBlETGrrKyrx4HOrr3wB+jeKqcvVL+m9tPqZGW Yp5EOgHlKycUKN/k3QITWlGiTAyhUX6YysJClPevZdCBhTHdFDIIgv+DIS/AgYtm+Q+0aivSBJC 2CzoV7n8Wd/jIoPbN8dKPw9WLwAD5xo= X-Received: by 2002:a05:622a:5792:b0:461:1fc9:61a3 with SMTP id d75a77b69052e-466b35d760amr125684031cf.9.1733148295173; Mon, 02 Dec 2024 06:04:55 -0800 (PST) X-Google-Smtp-Source: AGHT+IHcZ81mFmkrUNeLqEFEbFVMmp5vJUXLKK5kw3UAW0/7jWrcoiWhxK7YAGq7iyqIpT1YBAn9qA== X-Received: by 2002:a05:622a:5792:b0:461:1fc9:61a3 with SMTP id d75a77b69052e-466b35d760amr125683631cf.9.1733148294536; Mon, 02 Dec 2024 06:04:54 -0800 (PST) Received: from [192.168.212.120] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa5998e6dadsm513906866b.132.2024.12.02.06.04.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Dec 2024 06:04:54 -0800 (PST) Message-ID: Date: Mon, 2 Dec 2024 15:04:50 +0100 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/4] dt-bindindgs: i2c: qcom,i2c-geni: Document shared flag To: Mukesh Kumar Savaliya , Krzysztof Kozlowski , konrad.dybcio@linaro.org, andersson@kernel.org, andi.shyti@kernel.org, linux-arm-msm@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, conor+dt@kernel.org, agross@kernel.org, devicetree@vger.kernel.org, vkoul@kernel.org, linux@treblig.org, dan.carpenter@linaro.org, Frank.Li@nxp.com, konradybcio@kernel.org, bryan.odonoghue@linaro.org, krzk+dt@kernel.org, robh@kernel.org Cc: quic_vdadhani@quicinc.com References: <20241129144357.2008465-1-quic_msavaliy@quicinc.com> <20241129144357.2008465-2-quic_msavaliy@quicinc.com> <75f2cc08-e3ab-41fb-aa94-22963c4ffd82@quicinc.com> <904ae8ea-d970-4b4b-a30a-cd1b65296a9b@kernel.org> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: jb7GXfeEtZU77pfFDR1yy7Yyb2ZMmR9v X-Proofpoint-ORIG-GUID: jb7GXfeEtZU77pfFDR1yy7Yyb2ZMmR9v X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 adultscore=0 lowpriorityscore=0 bulkscore=0 mlxscore=0 malwarescore=0 spamscore=0 priorityscore=1501 clxscore=1015 suspectscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2411120000 definitions=main-2412020121 On 2.12.2024 1:55 PM, Mukesh Kumar Savaliya wrote: > > > On 12/2/2024 4:34 PM, Krzysztof Kozlowski wrote: >> On 02/12/2024 11:38, Mukesh Kumar Savaliya wrote: >>>> >>>> Come with one flag or enum, if needed, covering all your cases like this. >>>> >>> Let me explain, this feature is one of the additional software case >>> adding on base protocol support. if we dont have more than one usecase >>> or repurposing this feature, why do we need to add enums ? I see one >>> flag gpi_mode but it's internal to driver not exposed to user or expose >>> any usecase/feature. >>> >>> Below was our earlier context, just wanted to add for clarity. >>> -- >>>   > Is sharing of IP blocks going to be also for other devices? If yes, then >>>   > this should be one property for all Qualcomm devices. If not, then be >>>   > sure that this is the case because I will bring it up if you come with >>>   > one more solution for something else. >> >> >> You keep repeating the same. You won't receive any other answer. >> > So far i was in context to SEs. I am not sure in qualcomm SOC all cores supporting this feature and if it at all it supports, it may have it's own mechanism then what is followed in SE IP. I was probably thinking on my owned IP core hence i was revolving around. > > Hope this dt-binding i can conclude somewhere by seeking answer from other IP core owners within qualcomm. >>>   > >>> IP blocks like SE can be shared. Here we are talking about I2C sharing. >>> In future it can be SPI sharing. But design wise it fits better to add >>> flag per SE node. Same we shall be adding for SPI too in future. >> >> >> How flag per SE node is relevant? I did not ask to move the property. >> >>> >>> Please let me know your further suggestions. >> We do not talk about I2C or SPI here only. We talk about entire SoC. >> Since beginning. Find other patch proposals and align with rest of >> Qualcomm developers so that you come with only one definition for this >> feature/characteristic. Or do you want to say that I am free to NAK all >> further properties duplicating this one? I'm not sure a single property name+description can fit all possible cases here. The hardware being "shared" can mean a number of different things, with some blocks having hardware provisions for that, while others may have totally none and rely on external mechanisms (e.g. a shared memory buffer) to indicate whether an external entity manages power to them. Even here, I'm not particularly sure whether dt is the right place. Maybe we could think about checking for clock_is_enabled()? That's just an idea, as it may fall apart if CCF gets a .sync_state impl. Konrad