From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 331E82FD66B for ; Tue, 6 Jan 2026 19:43:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767728594; cv=none; b=fU0kvImKvhbv9mD1FYHR1WqC2I4Zvrsvv9fy4lo2cI+MIz2UoT56G6Y0Z6Pdjod7THE/iAdJpZ6a8x6krxavjm+iBDs59yDMmrjkorV33PtXN7ngD1EI4Q+EFDpg5pYl97BTosNWZz+og6WsaZTTjsTmlsfeelPYy4EKiSudaCs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767728594; c=relaxed/simple; bh=XfX+b6dLCq2w3dZ+DVIExRn/Lhy7ELFfs4bDhfz5P58=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uChNe9NC47+QZmt+sd8lmRDBRF7wqkJcrqHzrwIy+0utGGSCxbxReWR10lfHCo6tL4rixDrj4RbPduPm/h/WKomrak9kY8QABw4uYT7A3f+r6aORQSDhjDuU0w3nF17qzFYgs9guh3E6e4FphflP9CxIk1FiXbaojwi4qHPDsFc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UgHlRvwi; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GmR+fs5X; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UgHlRvwi"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GmR+fs5X" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 606HVga54090727 for ; Tue, 6 Jan 2026 19:43:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= DZDTYeigK/sfx0x25w6qJIS+ZT6X8Spw4/Jf9zAiFq4=; b=UgHlRvwiBVU1UiER MjTonP4NnLN281cVbJMepEz6xjVuQZi/mvBTl1Snz1NHRbsL6R6pvi5SaQ2iPH4M OtxXVE5S/PtYxPn231jPz8E8HEd8mQaImdqJ+4E7NJwASXwTy1kQ5AfCXXVwyKU4 YPsWlFOQXajzB0PVL1SRMm6WAGdQMLgxGKRFnTy7kHfmndl3QctN9UT6daMK5K4E lw0MTjC6rI/A7t3tJaH1PixgmIJsjtideRJ3ifvLWYTrjWyDF662JT0shsuTrZIm X/wCz0U22GRoU65BZdy764oVTggZSsiDaM9jy3JhCEU4aN3RorvyHl8LLC+Yh87y 26zCew== Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bgyun9rxf-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 06 Jan 2026 19:43:10 +0000 (GMT) Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-34c387d3eb6so1218965a91.2 for ; Tue, 06 Jan 2026 11:43:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1767728589; x=1768333389; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=DZDTYeigK/sfx0x25w6qJIS+ZT6X8Spw4/Jf9zAiFq4=; b=GmR+fs5XrokSfIOVQZud8YGXh6TweJblk9L+MYm3T6MevxBd2/dd9aegxmHVa55rnN fuzZBzn9E3r+Fw0sIaBpHAEWixxKSTR6WEp2w5bEUr47IJiAwejIL/nv4Cy628oiAibh zFaXTABhXrIBnbCYSmlISOOJFKduy+VVQemw/8ebpC/2bAsJ5GHzmwtV84/19fWQ9div 65PFKJ2w70sY6GukDAKLYioy/8SnCF9GInTv0xwcdpXjtq1Q43wOSfCQ53ypoDWECgMP ojKGNAlh4RDFxFm6xsbX4Rrn3UlCS7+yvhUc4vLy9iYchz90pf/be/Kpo4Fmo1ssCvgF F7IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767728589; x=1768333389; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DZDTYeigK/sfx0x25w6qJIS+ZT6X8Spw4/Jf9zAiFq4=; b=d+W3iOVVyElPCaZzYsYNOgWFk+JFwFkkmZzLFmy1NJlUsFp+0yY+OLrHERZqvj/oST th8idwUXfvFsGlw5hsDoHrd8xhT2L5/pDaDwX62q5Hk9n4gRLyqKPEz/KI14Ac5sT2YJ WcDewS1Ajqz2m8fFIB53fHdlDmYhnvcAhx2Bi60FB80viJEM4WhHLOJHl925pI9bPFRH qq7oaky20JQDbl/7fyfW+mC2VIHsAZ9DJ7W4vq7CzQDHB1R+8d3R7klvParB2wkpF8u2 KOvGYB3VMYj7YEwHKmi81l/wu0dnf+ZgbRtT3Bzx+UWAMcxPs2+ysCBYaCCMajOe9ibZ 8dIg== X-Forwarded-Encrypted: i=1; AJvYcCWwYNP8dOHf0gBA1injryV1tyWOYaArjN7vTbfMuyPjtbtOL0GC3nLqdAiSgWuCXAdEgVyyJESimvI=@vger.kernel.org X-Gm-Message-State: AOJu0YyU0ay6mqnL2zmeGLZG0bNFD++x1Hx6jULG3ffVUZFjVwDayJfW J1+2Jfp8GR7hlfqB/e4eIRfd/fFCZl34HWgTeal9MYOtKVL3tyuHBK+YM6QOGknV6W4sMyoK6xF JeRcWGTS0oHqnOJbOUxUPZbOX7yaV70yLZIwmPGu+euo3D1sczOvCTRLObNbvgn8= X-Gm-Gg: AY/fxX6DSeuVdrH5WEYgCiR/uMcQ1XaFpUUww+nE73mEhZvbw3K8JAiueHYoDvUlbG8 nlKpDy8sLLVhOaqqooddxU2D/PTkL6wiG8c8cp6B0tr1DDN4unBMdGNuFvUrVLru7xZe0DO1Hhv JRjhiHB1IW7x3LH12skLjxfO3x1prbutYKCg2keQLpHutR/YvTtYLgm71da47/1vr0v3/pO0HPg 8V0hiv3WOyjT7kjGInekk0Pp4YbjxGWDBGKLmaDUDYW4uB9GvOqldTfDHb6X+Pa+XOxeJ36maLl zdtDcDUHAJg4nxpVx1Ziric0Ja0cAjVYJGCCIV1M+yx+WkA0KmFMbl3bzeaQIuPaYqh/7ER3wPF gVztPQQqkHkJiaMHB4wedGgNOEICJF5J/r5GzbG1nmIKAvY0s7c35xy+fcsWtQUVJxg== X-Received: by 2002:a17:90b:4acb:b0:349:7f0a:381b with SMTP id 98e67ed59e1d1-34f68b4c603mr228438a91.8.1767728589200; Tue, 06 Jan 2026 11:43:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IGR7diURQX5/IXX/QMdmcVn16iPBI2ko8itYSY30OsuI6Gy/ChZZ4MFegFlC2SaEMUsbJ5HFg== X-Received: by 2002:a17:90b:4acb:b0:349:7f0a:381b with SMTP id 98e67ed59e1d1-34f68b4c603mr228406a91.8.1767728588676; Tue, 06 Jan 2026 11:43:08 -0800 (PST) Received: from [10.62.37.112] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-34f601351bcsm1113023a91.5.2026.01.06.11.43.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Jan 2026 11:43:08 -0800 (PST) Message-ID: Date: Tue, 6 Jan 2026 11:43:06 -0800 Precedence: bulk X-Mailing-List: linux-i2c@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 7/7] arm64: dts: qcom: sm8750: Add support for camss To: Krzysztof Kozlowski , Hangxiang Ma Cc: Loic Poulain , Robert Foss , Andi Shyti , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Todor Tomov , Vladimir Zapolskiy , Mauro Carvalho Chehab , Bryan O'Donoghue , linux-i2c@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, jeyaprakash.soundrapandian@oss.qualcomm.com References: <20251126-add-support-for-camss-on-sm8750-v1-0-646fee2eb720@oss.qualcomm.com> <20251126-add-support-for-camss-on-sm8750-v1-7-646fee2eb720@oss.qualcomm.com> <20251127-steadfast-red-koel-8c9bc8@kuoka> <6aa8ffc4-2fe5-44ad-8ac8-581e0697360f@oss.qualcomm.com> <355c3ae0-9603-4750-b83d-64447b6581ce@kernel.org> Content-Language: en-US From: Vijay Kumar Tumati In-Reply-To: <355c3ae0-9603-4750-b83d-64447b6581ce@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTA2MDE3MCBTYWx0ZWRfXzhNXkGteNLUH TdkZnZJNPWsjTVOXzmfmracqWmae43xMh3fFKST9VrwFUpuF8JVGKxp7s6AvdvBvwhXiDcr4t62 B20F68byGh1hCpNLF/un98reF6WY+wIRCuGteUzrAMFhcFjW4F3ZJEGPeznXwUNyWJyWUrZnSTK +VOVSzTMWLi/F6ebD8kZ2KJyxjLM2oi9jImpbaESyAFLXIV77b/5wVkDrxa1hBmui/glhYkgQEM H23cAwjUXO3xVZTfItXZmv6zMQw/1x7MRvU8dYxklUlDYzm1YKdgRMqGwCPhAVRet75jz6HTNf6 s11JX/2aX+BBLHSWS08nLvCKWZwxw4Kxy6HpaKm8bgLW/mlBnxwFmfvXPss7vbUmGCr9y+G9Y+P fWLRvTPTe/OJ1pxD7EPTkwKzSI+UlWCwsceRXSgQBCydNJ+KOHaOIVKl6S3JLoUIdzle2w6frwm bvd4P4SakoxT9WpHZ4g== X-Authority-Analysis: v=2.4 cv=YqIChoYX c=1 sm=1 tr=0 ts=695d65ce cx=c_pps a=RP+M6JBNLl+fLTcSJhASfg==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=vtVd1KKryTdkyhPdPdsA:9 a=QEXdDO2ut3YA:10 a=iS9zxrgQBfv6-_F4QbHw:22 X-Proofpoint-GUID: DpVtGQ7qd0vQQNoXneeIsiG019z_Suvv X-Proofpoint-ORIG-GUID: DpVtGQ7qd0vQQNoXneeIsiG019z_Suvv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2026-01-06_01,2026-01-06_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 suspectscore=0 impostorscore=0 bulkscore=0 malwarescore=0 phishscore=0 adultscore=0 clxscore=1015 lowpriorityscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2601060170 On 1/6/2026 11:20 AM, Krzysztof Kozlowski wrote: > On 06/01/2026 20:18, Krzysztof Kozlowski wrote: >> On 06/01/2026 19:40, Vijay Kumar Tumati wrote: >>> On 11/27/2025 12:12 AM, Krzysztof Kozlowski wrote: >>>> On Wed, Nov 26, 2025 at 01:38:40AM -0800, Hangxiang Ma wrote: > Look here^ > >>>>> + }; >>>>> + >>>>> + cci0: cci@ac7b000 { >>>> Looks completely mis-ordered/sorted. What are the nodes above and below? >>> Hi Krzysztof, sorry, not sure how you mean exactly. The ones above are >>> the pinctrl nodes. Each CCI has two masters using two GPIOs each, one >> Why would pinctrl nodes matter anyhow? Please read how DTS syntax works. >> >>> for clk and one for data. The ones below are the actual CCI HW nodes >>> that make use of the pinctrls. I believe this is inline with previous >>> generations. Have I missed something? Thanks. >> I wrote what is wrong. Is this maintaining proper sorting? Did you read >> DTS coding style? >> > > Heh, you received my review 1 day after your posting. > > You replied to my review 5-6 weeks after, yet you still expect me to > understand the context and provide clarifications. > > There is simpler way: NAK. > > You will not get your patches merged with such latency and such replies > not even trying to address the problem or learn about it. Agreed. Apologies for the delay. It was partly caused by the dependency that these patches have on Kaanapali patches and partly by vacations during Christmas. We will explore and address your concerns reg CCI nodes and push the next revision ASAP. Thanks for your understanding, Krzysztof. > > Best regards, > Krzysztof